Added absence validator for active model. #7155

robotex82 · 2012-07-25T15:13:18Z

Please accept my pull request for an absence validator.

See following discussion: https://groups.google.com/forum/#!topic/rubyonrails-core/KS_Olcnlw8w

I included passing tests and docs (Copied and adapted from the presence validator).

Thanks!

Saludos,

Roberto

paneq · 2012-07-25T16:25:05Z

+1

dolzenko · 2012-07-25T19:20:21Z

+1 Can confirm that needed this in almost every project with relatively complex models

robotex82 · 2012-07-31T14:03:12Z

I use it on trees, where i need attributes to be empty on roots. But I think, there should be better examples.

Anyone?

chancancode · 2012-10-04T02:27:38Z

With the strict option set to true, this could be used to verify the integrity of your models... so I'm +1 on this.

kendagriff · 2012-10-19T20:14:53Z

+1 – Require first and last names for users older than 13, but prevent update for younger than 13.

frodsan · 2012-10-27T05:17:16Z

activemodel/test/cases/validations/absence_validation_test.rb

+  end
+
+  def test_validates_acceptance_of_with_custom_error_using_quotes
+    Person.validates_absence_of :karma, :message => "This string contains 'single' and \"double\" quotes"


Please use 1.9 hash syntax. Thanks.

frodsan · 2012-10-27T05:17:34Z

I'm 👍 on this.

frodsan · 2012-10-27T05:20:48Z

activemodel/lib/active_model/validations/absence.rb

+
+module ActiveModel
+
+  # == Active Model Absence Validator


Could you move this title to class AbsenceValidator?

frodsan · 2012-10-27T05:21:24Z

@robotex82 Could you add a CHANGELOG entry please? Thanks!

carlosantoniodasilva · 2012-10-27T14:55:10Z

activemodel/test/cases/validations/absence_validation_test.rb

+    Topic.validates_absence_of(:title, :content)
+
+    t = Topic.new
+


Remove blank line.

carlosantoniodasilva · 2012-10-27T14:57:50Z

I wonder if we should use present instead of not_blank, thoughts?

@robotex82 thanks!

robotex82 · 2012-10-28T23:58:53Z

Thank you guys!

Sorry, I have been busy all the time, but i'll have a look at your suggestions asap. Hopefully before next weekend.

Do you see any chance to have this merged into master for v4.0?

carlosantoniodasilva · 2012-10-29T15:08:16Z

@robotex82 I believe so :)

robotex82 · 2012-11-07T12:59:54Z

I updated my local copy and changed add_on_not_blank to add_on_present.

I had some trouble with updating and rebasing - I admit, I lack experience on this topic - but I hope I didn't mess up.

Could someone please check my updated pull request?

What do I have to do next?

carlosantoniodasilva · 2012-11-07T13:03:53Z

@robotex82 thanks, but apparently you have some commits that shouldn't be there, can you try a new rebase, so that we can see only your PR diff?

robotex82 · 2012-11-07T13:23:11Z

I did:

git rebase upstream/master
git push --force

is that correct?

Excuse my noobish questions! I googled for the correct process of updating forks, rebasing, etc. but it's still not really clear to me.

carlosantoniodasilva · 2012-11-07T13:27:55Z

activemodel/lib/active_model/validations/absence.rb

+
+module ActiveModel
+  module Validations
+    # == Active Model Absence Validator


You can remove this comment.

carlosantoniodasilva · 2012-11-07T13:32:50Z

@robotex82 it's fine now, thanks. I added some comments, and we'll need a two changelog entries in Active Model, one for Errors#add_on_present and other for the validation itself, can you please add them, and squash your commits? Thanks.

Changed add_on_not_blank to add_on_present

robotex82 · 2012-11-07T16:11:19Z

Should I append or prepend to the changelog?

robotex82 · 2012-11-07T22:50:12Z

Hope it's ok now.....

carlosantoniodasilva · 2012-11-07T23:06:30Z

I added some minor comments, can you take a look at them before we merge? Also, what do you think about adding an example for the changelog entries, similar to the ones you added to the docs? (just look at other changelog examples to see how to format them).

Other than that, just squash your commits and we're good to go :). Thanks!

robotex82 · 2012-11-08T21:44:11Z

Well, I added the example to the changelog. But again I'm stuck with git :(

I have a commit history like that:

1a9f792 Updated changelog
072b977 Add `ActiveModel::Validations::AbsenceValidator`, a validator to check the  absence of attributes. Add `ActiveModel::Errors#add_on_present` method. Adds error messages to presen
c35fa0b Removed blank lines Changed add_on_not_blank to add_on_present
02e8148 Added absence validator for active model.
c233b2f Fix guides home links and maintain compatibility with small screens

So I thought I google how to squash commits. I tried some things but I keep getting errors or the commits don't go away.

So, please, could some of you experieced people, tell me how I package things up?

Thanks, and sorry again...squashing, rabaseing, etc. is new stuff to me.

@carlosantoniodasilva: I couldn't find your comments, where are they?

carlosantoniodasilva · 2012-11-08T22:18:32Z

@robotex82 just look at the pull request Files Changed tab with the diff, and you'll see the comments (just ignore the "Remove blank line." ones).

Now about the rebase, Jon has just given a quick explanation here, but if you still have doubts, please let me know. Thanks!

steveklabnik · 2012-11-08T22:19:27Z

@robotex82 I wrote something up explaining rebase here: http://blog.steveklabnik.com/posts/2012-11-08-how-to-squash-commits-in-a-github-pull-request

carlosantoniodasilva · 2012-11-08T22:23:16Z

@steveklabnik Ah true, I forgot that, awesome thanks ❤️

steveklabnik · 2012-11-08T22:29:32Z

You didn't forget that at all; I saw this comment, was like "man, I really need to put this in a place where I can find it again," posted it, and then linked it here. ;)

carlosantoniodasilva · 2012-11-08T22:34:15Z

Haha sorry, I thought I had seen that among your other contribution related posts. Awesome anyway, you were fast on that 😄

This is already handled by #find, it's a duplicate check, since find_with_ids is not called from anywhere else.

Closes rails#8121 The `plugin new` generator always adds the dummy app rake tasks, when a dummy app was created.

[ci skip]

…bjects with unstable class names and instance variables. Refactor FlashHash to take values for its ivars in the constructor, to pretty up FlashHash.from_session_value. Remove stale comment on FlashHash: it is no longer Marshaled in the session so we can change its implementation. Remove blank lines I introduced in controller/test_case.rb. Unit tests for FlashHash#to_session_value. Put in a compatibility layer to accept FlashHash serializations from Rails 3.0+. Test that Rails 3.2 session flashes are correctly converted to the new format. Remove code path for processing Rails 3.0 FlashHashes since they can no longer deserialize.

…k the absence of attributes. Add `ActiveModel::Errors#add_on_present` method. Adds error messages to present attributes.

robotex82 · 2012-11-08T22:53:17Z

This looks ....wrong?!

carlosantoniodasilva · 2012-11-08T22:55:55Z

Looks like there are some extra commits now :)

robotex82 · 2012-11-08T23:38:14Z

OT: Time to read a book about GIT. Suggestions?

steveklabnik · 2012-11-08T23:44:11Z

http://progit.org

robotex82 · 2012-11-14T10:37:42Z

I read the section on rebasing, but I don't get this right. :(

How do we get this right? Should I create a completely new pull request?

steveklabnik · 2012-11-14T23:12:30Z

Do this: http://blog.steveklabnik.com/posts/2012-11-08-how-to-squash-commits-in-a-github-pull-request

But don't bother with the -i.

steveklabnik · 2012-12-15T21:29:51Z

@robotex82 Because it's been a month, and you're obviously having some trouble, and I had some time this morning, I took care of this.

You can see the commit here: d72a07f

I also took care of @frodsan 's comment about the 1.9 hash syntax, and double checked @carlosantoniodasilva 's comments about blank lines.

Thank you for your pull request, hopefully you will overcome the git beast next time ;)

wilmoore · 2012-12-16T00:17:14Z

@robotex82: I highly recommend the Mastering Git series by @tlberglund and @matthewmccullough:

Full Disclosure: I know them both personally (and I appear in one of the videos) so I am a bit biased -- but trust me, watch these videos a few times through and you will level-up in your git-fu for sure.

robotex82 · 2013-01-09T01:59:53Z

Awesome, thank you guys! ❤️

Sorry for the late answer, but I've been very busy!

While checking the commit, I discovered, that the CHANGELOG is messed up a little bit:

Actual:

*   Add `ActiveModel::Validations::AbsenceValidator`, a validator to check the
    absence of attributes.

        class Person
          include ActiveModel::Validations

          attr_accessor :first_name
          validates_absence_of :first_name
        end

        person = Person.new
        person.first_name = "John"
        person.valid?
        # => false
        person.errors.messages
        # => {:first_name=>["must be blank"]}

    *Roberto Vasquez Angel*

*   `[attribute]_changed?` now returns `false` after a call to `reset_[attribute]!`

Shouldn't it be:

    *Roberto Vasquez Angel*

*   Add `ActiveModel::Validations::AbsenceValidator`, a validator to check the
    absence of attributes.

        class Person
          include ActiveModel::Validations

          attr_accessor :first_name
          validates_absence_of :first_name
        end

        person = Person.new
        person.first_name = "John"
        person.valid?
        # => false
        person.errors.messages
        # => {:first_name=>["must be blank"]}

*   `[attribute]_changed?` now returns `false` after a call to `reset_[attribute]!`

How do we get this right?

Thanks again!

carlosantoniodasilva · 2013-01-09T02:19:16Z

Not sure what you mean, but the name goes after the change, at the end.

frodsan reviewed Oct 27, 2012
View changes

carlosantoniodasilva reviewed Oct 27, 2012
View changes

carlosantoniodasilva reviewed Nov 7, 2012
View changes

robotex82 added 2 commits November 7, 2012 17:09

Added absence validator for active model.

02e8148

Removed blank lines

c35fa0b

Changed add_on_not_blank to add_on_present

carlosantoniodasilva and others added 11 commits November 8, 2012 23:37

Remove block given check from private find_with_ids

838c5e8

This is already handled by #find, it's a duplicate check, since find_with_ids is not called from anywhere else.

Use cached quoted_table_name instead of going through the connection

4995979

Remove not used indifferent_access requires from Base and FinderMethods

fda107b

plugin new adds dummy app tasks when necessary.

a085d27

Closes rails#8121 The `plugin new` generator always adds the dummy app rake tasks, when a dummy app was created.

Add CHANGELOG entry for rails#8108 on master too.

6f8b95c

[ci skip]

Add test to avoid regression of 58e48d5

50337da

test case to lock down the behavior of rails#7842

4d10d8b

routing prefix slash replacement is no longer necessary

4c14e05

Remove free usage of #tap

9a68393

Add ActiveModel::Validations::AbsenceValidator, a validator to chec…

64df864

…k the absence of attributes. Add `ActiveModel::Errors#add_on_present` method. Adds error messages to present attributes.

steveklabnik closed this Dec 15, 2012

Added absence validator for active model. #7155

Added absence validator for active model. #7155

robotex82 commented Jul 25, 2012

paneq commented Jul 25, 2012

dolzenko commented Jul 25, 2012

robotex82 commented Jul 31, 2012

chancancode commented Oct 4, 2012

kendagriff commented Oct 19, 2012

frodsan Oct 27, 2012

frodsan commented Oct 27, 2012

frodsan Oct 27, 2012

frodsan commented Oct 27, 2012

carlosantoniodasilva Oct 27, 2012

carlosantoniodasilva commented Oct 27, 2012

robotex82 commented Oct 28, 2012

carlosantoniodasilva commented Oct 29, 2012

robotex82 commented Nov 7, 2012

carlosantoniodasilva commented Nov 7, 2012

robotex82 commented Nov 7, 2012

carlosantoniodasilva Nov 7, 2012

carlosantoniodasilva commented Nov 7, 2012

robotex82 commented Nov 7, 2012

robotex82 commented Nov 7, 2012

carlosantoniodasilva commented Nov 7, 2012

robotex82 commented Nov 8, 2012

carlosantoniodasilva commented Nov 8, 2012

steveklabnik commented Nov 8, 2012

carlosantoniodasilva commented Nov 8, 2012

steveklabnik commented Nov 8, 2012

carlosantoniodasilva commented Nov 8, 2012

robotex82 commented Nov 8, 2012

carlosantoniodasilva commented Nov 8, 2012

robotex82 commented Nov 8, 2012

steveklabnik commented Nov 8, 2012

robotex82 commented Nov 14, 2012

steveklabnik commented Nov 14, 2012

steveklabnik commented Dec 15, 2012

wilmoore commented Dec 16, 2012

robotex82 commented Jan 9, 2013

carlosantoniodasilva commented Jan 9, 2013

Added absence validator for active model. #7155

Added absence validator for active model. #7155

Conversation

robotex82 commented Jul 25, 2012

paneq commented Jul 25, 2012

dolzenko commented Jul 25, 2012

robotex82 commented Jul 31, 2012

chancancode commented Oct 4, 2012

kendagriff commented Oct 19, 2012

frodsan Oct 27, 2012

Choose a reason for hiding this comment

frodsan commented Oct 27, 2012

frodsan Oct 27, 2012

Choose a reason for hiding this comment

frodsan commented Oct 27, 2012

carlosantoniodasilva Oct 27, 2012

Choose a reason for hiding this comment

carlosantoniodasilva commented Oct 27, 2012

robotex82 commented Oct 28, 2012

carlosantoniodasilva commented Oct 29, 2012

robotex82 commented Nov 7, 2012

carlosantoniodasilva commented Nov 7, 2012

robotex82 commented Nov 7, 2012

carlosantoniodasilva Nov 7, 2012

Choose a reason for hiding this comment

carlosantoniodasilva commented Nov 7, 2012

robotex82 commented Nov 7, 2012

robotex82 commented Nov 7, 2012

carlosantoniodasilva commented Nov 7, 2012

robotex82 commented Nov 8, 2012

carlosantoniodasilva commented Nov 8, 2012

steveklabnik commented Nov 8, 2012

carlosantoniodasilva commented Nov 8, 2012

steveklabnik commented Nov 8, 2012

carlosantoniodasilva commented Nov 8, 2012

robotex82 commented Nov 8, 2012

carlosantoniodasilva commented Nov 8, 2012

robotex82 commented Nov 8, 2012

steveklabnik commented Nov 8, 2012

robotex82 commented Nov 14, 2012

steveklabnik commented Nov 14, 2012

steveklabnik commented Dec 15, 2012

wilmoore commented Dec 16, 2012

robotex82 commented Jan 9, 2013

carlosantoniodasilva commented Jan 9, 2013