Ported PR #4856 to 3-2-stable. #7299

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
3 participants
Contributor

iHiD commented Aug 9, 2012

Hi guys,
#4856 was committed to master, but never backported to 3-2-stable. I only realised when I upgraded Rails to the latest 3-2 version and it broke my app. I'd been using a patched version locally. My fail.

The files that were updated on master haven't changed on 3-2-stable, so it should be very straightforward.

Thanks,
iHiD

Owner

rafaelfranca commented Aug 9, 2012

The backport is not easy. You will need to backport the Oracle fixes that @yahonda did.

I think that all the fixes are linked at #4856.

Contributor

iHiD commented Aug 9, 2012

Thanks for the feedback, @rafaelfranca.

As far as I can tell, there's just one small change in #7173. I've backported #7173. Can you confirm this please and let me know if there's another commit that's not referenced that I've missed? Thanks.

rafaelfranca added a commit that referenced this pull request Aug 9, 2012

Owner

rafaelfranca commented Aug 9, 2012

Merged. Thanks

Contributor

iHiD commented Aug 9, 2012

Thanks, @rafaelfranca.

Contributor

yahonda commented Aug 9, 2012

This fix also works with Oracle. Thanks for taking care of it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment