#4938 Fix launching performance tests #7416

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
4 participants
@route
Contributor

route commented Aug 22, 2012

When we run rake test:benchmark for performance tests it raises
ArgumentError that file --benchmark not found. It happens because
gem 'test-unit' passes remaining options to the tests, whereas mintest
doesn't do it.

@carlosantoniodasilva

This comment has been minimized.

Show comment
Hide comment
@carlosantoniodasilva

carlosantoniodasilva Aug 22, 2012

Member

Nice! I'll give it a try when I find some time here, thanks!

(linking to #4938)

Nice! I'll give it a try when I find some time here, thanks!

(linking to #4938)

@route

This comment has been minimized.

Show comment
Hide comment
@route

route Aug 22, 2012

Contributor

When I want to test my code on performance(for example ActiveRecord or pure Arel/SQL queries), often I have to create big amount of data and for now it is a problem to run rake test:{benchmark,profile} because they purge database before launching tests. WDYT @carlosantoniodasilva can we make it optional or do you have another idea about it?

Contributor

route commented Aug 22, 2012

When I want to test my code on performance(for example ActiveRecord or pure Arel/SQL queries), often I have to create big amount of data and for now it is a problem to run rake test:{benchmark,profile} because they purge database before launching tests. WDYT @carlosantoniodasilva can we make it optional or do you have another idea about it?

#4938 Fix launching performance tests
When we run `rake test:benchmark` for performance tests it raises
ArgumentError that file --benchmark not found. It happens because
gem 'test-unit' passes remaining options to the tests, whereas mintest
doesn't do it.
@matthewrobertson

This comment has been minimized.

Show comment
Hide comment
@matthewrobertson

matthewrobertson Nov 13, 2012

Contributor

I tested this patch out with ruby-1.9.3-p194 and it fixed similar issues I was having with not being able to run rails benchmarker 'Some.code'

Contributor

matthewrobertson commented Nov 13, 2012

I tested this patch out with ruby-1.9.3-p194 and it fixed similar issues I was having with not being able to run rails benchmarker 'Some.code'

@carlosantoniodasilva

This comment has been minimized.

Show comment
Hide comment
@carlosantoniodasilva

carlosantoniodasilva Nov 13, 2012

Member

@matthewrobertson thanks for reporting, this is in my todo list to check asap :).

@matthewrobertson thanks for reporting, this is in my todo list to check asap :).

@senny senny referenced this pull request in rails/rails-perftest Jan 14, 2013

Merged

port PR rails/rails#7416 #2

senny added a commit to rails/rails-perftest that referenced this pull request Jan 14, 2013

@senny

This comment has been minimized.

Show comment
Hide comment
@senny

senny Jan 14, 2013

Member

As of rails 4 {#8876) performance tests were extracted into a separate gem: https://github.com/rails/rails-perftest

I ported the PR over to that gem and fixed two bugs: rails/rails-perftest#2

I'm closing this one for now. I did not merge the PR into rails-perftest. If you have comments let me know on here: rails/rails-perftest#2

thanks for your work!

Member

senny commented Jan 14, 2013

As of rails 4 {#8876) performance tests were extracted into a separate gem: https://github.com/rails/rails-perftest

I ported the PR over to that gem and fixed two bugs: rails/rails-perftest#2

I'm closing this one for now. I did not merge the PR into rails-perftest. If you have comments let me know on here: rails/rails-perftest#2

thanks for your work!

@senny senny closed this Jan 14, 2013

senny added a commit to rails/rails-perftest that referenced this pull request Feb 4, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment