We always see the follwing warning, when executing rake test_mysql
...warning: instance variable errno not initialized...
I know we shouldn't hide warnings, but I guess that development for mysql gem is not active.
according to https://github.com/luislavena/mysql-gem/blob/master/ext/mysql_api/mysql.c#L1873
and https://github.com/luislavena/mysql-gem/blob/master/ext/mysql_api/mysql.c#L171, we can't access this iv ?
This message is very annoying yeah, and I'm happy to merge it. I just thought that perhaps we should move it to our tests setup instead of the connection adapter, since it's a hack for our tests only, wdyt?
I agree with @carlosantoniodasilva on this. We should probably move to the test cases.
Fix annoy warning, when executing testcase.
@carlosantoniodasilva @tenderlove I moved to the testcases.
BTW, I found the below comment in mysql_adapter
8 class Mysql
9 class Time
11 # This monkey patch is for test_additional_columns_from_join_table
12 def to_date
13 Date.new(year, month, day)
Should we move it to the testcases ?
@kennyj I don't think this code is used only in tests. I guess it is fixing some issue. But I'm just guessing
When I remove Mysql::Time#to_date, many testcases are failed, and I confirm some functionalities depend on the method. I'll remove this comment.
Remove expired comment. This method is used from other place.
I added 48498da .