Extract ActiveRecord::SessionStore from Rails #7436
Conversation
|
|
|
Pull request updated with changelog. |
|
Prem, the "Action Controller Overview" and "Configuring Rails Applications" guides need to be updated as well. |
|
@fxn sure thing. going to do that when I get home. |
|
Yay |
| @@ -1,5 +1,8 @@ | |||
| ## Rails 4.0.0 (unreleased) ## | |||
|
|
|||
| * ActiveRecord::SessionStore has been extracted from Active Record as `activerecord-session_store` | |||
| gem. Plese read the `README.md` file on the gem for the usage. *Prem Sichanugrist* | |||
|
Loving this! <3 |
|
|
|
|
|
Pull request update with the doc fix from @josevalim and guides are updated from @fxn's request. The gem has also been pushed to rails/activerecord-session_store |
| @@ -1,5 +1,8 @@ | |||
| ## Rails 4.0.0 (unreleased) ## | |||
|
|
|||
| * Setting `config.session_store` to `:active_record_store` will now break unless you have | |||
| `activerecord-session_store` gem installed. *Prem Sichanugrist* | |||
|
|
|||
There was a problem hiding this comment.
We can say "ActiveRecord::SessionStore is extracted out of Rails into a gem activerecord-session_store. Setting config.session_store to :active_record_store will no longer work and will break if the activerecord-session_store gem isn't available". More informative imo.
EDIT: Now I see, you've done this in the AR changelog. Could do it here too.
|
Reasonable! |
|
@homakov might be, maybe open up another ticket requesting for comment on that? Then we can take it from there. |
This functionality will be available from gem `active_record-session_store` instead.
|
Pull request updated with updated documentation feedback from @vijaydev |
|
Meta session migration generator has been removed, @josevalim |
| @@ -125,8 +125,6 @@ def session_store(*args) | |||
| case @session_store | |||
| when :disabled | |||
| nil | |||
| when :active_record_store | |||
There was a problem hiding this comment.
I believe we should raise an error here. Otherwise people will get constant ActionDispatch::Session::ActiveRecordStore not found error. Tell them it was moved to a plugin and that they should set config.session_store = ActiveRecord::SessionStore.
Tell people to install `activerecord-session_store` gem when it's not installed instead ofraising `NameError` on missing `ActionDispatch::Session::ActiveRecordStore`.
|
Ok, error message has been added. I guess this is ready to roll. |
|
|
…sion_store Extract ActiveRecord::SessionStore from Rails
This functionality will be available from gem
active_record-session_storeinstead. The gem is currently hosted at https://github.com/sikachu/activerecord-session_store, and I'll be pushing to rails/ soon.