Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decimal form has better browser support. #7513

Merged
merged 1 commit into from Sep 9, 2012

Conversation

kalys
Copy link
Contributor

@kalys kalys commented Sep 3, 2012

&#39 dates back to SGML when &#x27 was introduced in HTML 4.0

Reference:
ruby/ruby@bbb6b5e#commitcomment-1800099

@carlosantoniodasilva
Copy link
Member

Looks like a fine change to me, but I'm going to ask for some more feedback before. Thanks!

/cc @tenderlove

@rafaelfranca
Copy link
Member

I'm fine with this change too.

@rafaelfranca
Copy link
Member

You will need to update some tests in actionpack and railties too.

@carlosantoniodasilva
Copy link
Member

@kalys looks good, can you please add a changelog entry, and squash the commits? Thanks.

@kalys
Copy link
Contributor Author

kalys commented Sep 9, 2012

@carlosantoniodasilva Done.

@@ -142,4 +142,6 @@

* Remove deprecated ActiveSupport::JSON::Variable. *Erich Menge*

* ```ERB::Util.html_escape``` encodes single quote as ```#39```. Decimal form has better support in old browsers. *Kalys Osmonov*

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, but I have to bother you once again before merging :). Please move the changelog line to the top of the list, we usually add them to the top. Also, I think a single backtick around the code would be enough.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. Thank you.

@carlosantoniodasilva
Copy link
Member

There we go, merging, thanks!

carlosantoniodasilva added a commit that referenced this pull request Sep 9, 2012
ERB::Util.html_escape encodes single quote as #39. Decimal form has better support in old browsers.
@carlosantoniodasilva carlosantoniodasilva merged commit be8685d into rails:master Sep 9, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants