Decimal form has better browser support. - #7513
Merged
Merged
Conversation
Member
|
Looks like a fine change to me, but I'm going to ask for some more feedback before. Thanks! /cc @tenderlove |
Member
|
I'm fine with this change too. |
Member
|
You will need to update some tests in actionpack and railties too. |
Member
|
@kalys looks good, can you please add a changelog entry, and squash the commits? Thanks. |
Contributor
Author
|
@carlosantoniodasilva Done. |
Member
There was a problem hiding this comment.
Thanks, but I have to bother you once again before merging :). Please move the changelog line to the top of the list, we usually add them to the top. Also, I think a single backtick around the code would be enough.
Member
|
There we go, merging, thanks! |
carlosantoniodasilva
added a commit
that referenced
this pull request
Sep 9, 2012
ERB::Util.html_escape encodes single quote as #39. Decimal form has better support in old browsers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
' dates back to SGML when ' was introduced in HTML 4.0
Reference:
ruby/ruby@bbb6b5e#commitcomment-1800099