Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decimal form has better browser support. #7513

Merged
merged 1 commit into from Sep 9, 2012

Conversation

Projects
None yet
3 participants
@kalys
Copy link
Contributor

kalys commented Sep 3, 2012

&#39 dates back to SGML when &#x27 was introduced in HTML 4.0

Reference:
ruby/ruby@bbb6b5e#commitcomment-1800099

@carlosantoniodasilva

This comment has been minimized.

Copy link
Member

carlosantoniodasilva commented Sep 3, 2012

Looks like a fine change to me, but I'm going to ask for some more feedback before. Thanks!

/cc @tenderlove

@rafaelfranca

This comment has been minimized.

Copy link
Member

rafaelfranca commented Sep 3, 2012

I'm fine with this change too.

@rafaelfranca

This comment has been minimized.

Copy link
Member

rafaelfranca commented Sep 3, 2012

You will need to update some tests in actionpack and railties too.

@carlosantoniodasilva

This comment has been minimized.

Copy link
Member

carlosantoniodasilva commented Sep 8, 2012

@kalys looks good, can you please add a changelog entry, and squash the commits? Thanks.

@kalys

This comment has been minimized.

Copy link
Contributor Author

kalys commented Sep 9, 2012

@@ -142,4 +142,6 @@

* Remove deprecated ActiveSupport::JSON::Variable. *Erich Menge*

* ```ERB::Util.html_escape``` encodes single quote as ```#39```. Decimal form has better support in old browsers. *Kalys Osmonov*

This comment has been minimized.

Copy link
@carlosantoniodasilva

carlosantoniodasilva Sep 9, 2012

Member

Thanks, but I have to bother you once again before merging :). Please move the changelog line to the top of the list, we usually add them to the top. Also, I think a single backtick around the code would be enough.

This comment has been minimized.

Copy link
@kalys

kalys Sep 9, 2012

Author Contributor

Done. Thank you.

@carlosantoniodasilva

This comment has been minimized.

Copy link
Member

carlosantoniodasilva commented Sep 9, 2012

There we go, merging, thanks!

carlosantoniodasilva added a commit that referenced this pull request Sep 9, 2012

Merge pull request #7513 from kalys/master
ERB::Util.html_escape encodes single quote as #39. Decimal form has better support in old browsers.

@carlosantoniodasilva carlosantoniodasilva merged commit be8685d into rails:master Sep 9, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.