set the configured #inheritance_column on #become (#7503) #7514

Merged
merged 1 commit into from Sep 3, 2012

Conversation

Projects
None yet
2 participants
Member

senny commented Sep 3, 2012

PR for 3-2-stable as described in #7506

  • I changed public_send to send
  • I added a CHANGELOG.md entry
@senny @senny senny set the configured #inheritance_column on #become (#7503)
I had to create a new table because I needed an STI table,
which does not have both a "type" and a "custom_type"

the test fails with:
  1) Error:
test_alt_becomes_works_with_sti(InheritanceTest):
NoMethodError: undefined method `type=' for #<Cabbage id: 1, name: "my cucumber", custom_type: "Cucumber">
    /Users/username/Projects/rails/activemodel/lib/active_model/attribute_methods.rb:432:in `method_missing'
    /Users/username/Projects/rails/activerecord/lib/active_record/attribute_methods.rb💯in `method_missing'
    /Users/username/Projects/rails/activerecord/lib/active_record/persistence.rb:165:in `becomes'
    test/cases/inheritance_test.rb:134:in `test_becomes_works_with_sti'
    test/cases/inheritance_test.rb:140:in `test_alt_becomes_works_with_sti'

Conflicts:

	activerecord/test/cases/inheritance_test.rb
01d09a6
Member

senny commented Sep 3, 2012

@rafaelfranca changes for 3-2-stable

@rafaelfranca rafaelfranca added a commit that referenced this pull request Sep 3, 2012

@rafaelfranca rafaelfranca Merge pull request #7514 from senny/issue_7503_3_2_stable
set the configured #inheritance_column on #become (#7503)
87ac5b4

@rafaelfranca rafaelfranca merged commit 87ac5b4 into rails:3-2-stable Sep 3, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment