Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

AS::Callbacks: deprecate monkey patch of object callbacks #7560

Merged
merged 1 commit into from Sep 7, 2012

Conversation

Projects
None yet
2 participants
Contributor

bogdan commented Sep 7, 2012

Deprecate yet another on the fly monkey patch of objects in AS::Callbacks.
This one is probably related to before_filters:

before_filter MyFilter.new

class MyFilter
  def filter(controller)
  end
end

is now deprecated with recommendation to use:

before_filter MyFilter.new

class MyFilter
  def before(controller)
  end
end

@josevalim josevalim added a commit that referenced this pull request Sep 7, 2012

@josevalim josevalim Merge pull request #7560 from bogdan/deprecate_callbacks_monkeypatch
AS::Callbacks: deprecate monkey patch of object callbacks
c5ac6da

@josevalim josevalim merged commit c5ac6da into rails:master Sep 7, 2012

@bogdan bogdan added a commit to bogdan/rails that referenced this pull request Sep 10, 2012

@bogdan bogdan Changelog entry for PR #7560 ca80067

@josevalim josevalim added a commit that referenced this pull request Sep 10, 2012

@josevalim josevalim Merge pull request #7591 from bogdan/callbacks-changelog
Changelog entry for PR #7560
43d312a

@bogdan bogdan added a commit to bogdan/rails that referenced this pull request Sep 10, 2012

@bogdan bogdan Revert "Changelog entry for PR #7560"
This reverts commit ca80067.
Entry already added in 895233
f11fc73

@josevalim josevalim added a commit that referenced this pull request Sep 10, 2012

@josevalim josevalim Merge pull request #7592 from bogdan/callbacks-changelog
Revert "Changelog entry for PR #7560"
416884c

@kassio kassio added a commit to kassio/rails that referenced this pull request Jan 29, 2014

@kassio kassio Fix documentation of new controller filters api [ci skip]
The api for filters with classes change and the guides weren't updated.
Now the class must respond for methods with the same name as the filter,
so the `before_action` calls a `before` method, and so on.

filter has been deprecated in 4.0.0 and has been removed in 4.1.0: #7560
cdc142a

@kassio kassio added a commit to kassio/rails that referenced this pull request Jan 29, 2014

@kassio kassio Fix documentation of new controller filters api [ci skip]
The api for filters with classes change and the guides weren't updated.
Now the class must respond for methods with the same name as the filter,
so the `before_action` calls a `before` method, and so on.

The method `#filter` has been deprecated in 4.0.0 and has been removed
in 4.1.0: #7560
6b51a23

@kassio kassio added a commit to kassio/rails that referenced this pull request Jan 29, 2014

@kassio kassio Fix documentation of new controller filters api [ci skip]
The api for filters with classes change and the guides weren't updated.
Now the class must respond for methods with the same name as the filter,
so the `before_action` calls a `before` method, and so on.

The method `#filter` has been deprecated in 4.0.0 and has been removed
in 4.1.0: #7560
4256662

@bogdan bogdan deleted the bogdan:deprecate_callbacks_monkeypatch branch May 7, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment