removed warning: shadowing outer local variable #7571

Merged
merged 1 commit into from Sep 9, 2012

3 participants

@arunagw
Ruby on Rails member

No description provided.

@carlosantoniodasilva carlosantoniodasilva and 1 other commented on an outdated diff Sep 8, 2012
activerecord/lib/active_record/railtie.rb
@@ -71,7 +71,7 @@ class Railtie < Rails::Railtie
end
end
- initializer "active_record.check_schema_cache_dump" do |app|
+ initializer "active_record.check_schema_cache_dump" do |_app|
@carlosantoniodasilva
Ruby on Rails member
carlosantoniodasilva added a line comment Sep 8, 2012

Perhaps we could just kill the argument, since it is apparently not used inside the initializer body?

@arunagw
Ruby on Rails member
arunagw added a line comment Sep 9, 2012

Yes. Nowhere used. Let me update this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@arunagw
Ruby on Rails member

@carlosantoniodasilva updated :-)

@rafaelfranca rafaelfranca merged commit aee9b6a into rails:master Sep 9, 2012
@carlosantoniodasilva
Ruby on Rails member

@arunagw thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment