Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

3 2 stable #7632

Merged
merged 1 commit into from Sep 13, 2012

Conversation

Projects
None yet
2 participants

stevecj commented Sep 13, 2012

Back-port test coverage to preserve the health of the PostgreSQL auto-reconnection functionality.

Owner

rafaelfranca commented Sep 13, 2012

Could you squash you commits and add changelog entry? Also could you link the origin issue

Backport PostgreSQL auto-reconnect test coverage
6d5f4de
Simulated & actual (manual/skipped) PostgreSQL auto-reconnection tests.

4b1bca0
Stop being silly with formatting of method aliasing.

c381d5c
Fix just-plain-wrongness of psql auto-reconnect test.

1e17a9d
Fix only-once stub logic.

f16c2043826ec1991cf94fe17cb671507b7a7f51
Changelog for PostgreSQL auto-reconnect test coverage backport.

stevecj commented Sep 13, 2012

PostgreSQL auto-reconnect functionality has been broken at least twice in different ways. Test coverage was added with the fix in #6654 with corrections in #7292 and #7294.

Back-porting the the test coverage from those pull requests should help prevent future breakages of this functionality.

Note that the bug fixed in #6654 has never existed in Rails 3.2.x, but the one fixed in #6477 did exist in earlier 3.2.x patch versions.

rafaelfranca added a commit that referenced this pull request Sep 13, 2012

@rafaelfranca rafaelfranca merged commit 84c7896 into rails:3-2-stable Sep 13, 2012

Owner

rafaelfranca commented Sep 13, 2012

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment