Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Removing to_shorthand to fix #6497 #7668
I think it's that it doesn't work in the title, it has to be in the body. Yeah: https://github.com/blog/831-issues-2-0-the-next-generation
Then I think it'll work, since the commit has the same name as the pull request.
About the change itself, I have no idea if this could break something, I can't imagine a scenario that adding the module scope would be wrong, but presumably the
I am trying to add a test for this but I am not sure how to reproduce this error in the test env. Tried this:
But it doesn't add the
My guess is this specific path is added somewhere later in the process when the engine is loaded and the isolated flag is true, then it fixes the path.
So, how should I proceed with testing? Is this the right direction? Should I keep it on mapper_test, or move it somewhere else?
Sorry for all these questions... This is my first rails contribution