Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Fix 6 failing AR XML serialization tests. #7722

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants

stevecj commented Sep 21, 2012

Regexes expected empty tags, but got self-closing tags.

Tests passed after making regexes same as in corresponding tests on master branch.

Steve Jorgensen Fix 6 failing AR XML serialization tests.
Regexes expected empty tags, but got self-closing tags.

Tests passed after making regexes same as in corresponding tests on master branch.
993ac30

Thanks. I think it might be better to cherry-pick these commits: d65adc7, 77dd3be, 146eaf3, because there are other failures in Active Record and Active Support. Or you can do the changes in those places as well, and squash everything into one commit, that I'll merge.

Contributor

ayrton commented Oct 15, 2012

@carlosantoniodasilva I believe this issue can be closed now, this was added by you in ba4a6c2

stevecj commented Oct 15, 2012

Sorry I never got back to it. Got pulled onto other things.

@stevecj stevecj closed this Oct 15, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment