Zlib::GzipWriter can take two optional arguments, compression level and strategy. This fix is to pass these arguments.
Do you think there's some way that a test could be written for this?
I have no good idea for testing wrapper object. If I could have a testing method, I write a code.
I wrote some test codes for gzip options.
Please, can you add docs about the new options? Thanks.
/cc @pixeltrix @fxn, what do you guys think about this?
Looks good to me, the signature of the method shown by RDoc will be enough documentation for those parameters I believe, since they match gzip jargon and are self-explanatory.
We would need a CHANGELOG entry though.
Ditto to what @fxn said - also squash the commits please.
Hi @beyond a CHANGELOG entry and commits squash is all we need here, if you find a minute we'll apply.
Hi @fxn I wrote a CHANGELOG and squashed commits.
Hi @beyond, could you please revise this pull request? I tried pulling the branch to do the merge myself, but some changes related to engines come down for some reason.
added compress options for gzip
added test for compress options of gzip
Hi @fxn This branch rebased the master branch and fixed conflicts.
Looking good, thanks very much!