Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

added compress options for gzip #7730

Merged
merged 1 commit into from Feb 10, 2013

Conversation

Projects
None yet
5 participants
Contributor

beyond commented Sep 22, 2012

Zlib::GzipWriter can take two optional arguments, compression level and strategy. This fix is to pass these arguments.

http://www.ensta-paristech.fr/~diam/ruby/online/ruby-doc-stdlib/libdoc/zlib/rdoc/classes/Zlib/GzipWriter.html

Member

steveklabnik commented Sep 22, 2012

Do you think there's some way that a test could be written for this?

Contributor

beyond commented Sep 22, 2012

I have no good idea for testing wrapper object. If I could have a testing method, I write a code.

Contributor

beyond commented Sep 25, 2012

I wrote some test codes for gzip options.

@frodsan frodsan commented on the diff Oct 26, 2012

activesupport/lib/active_support/gzip.rb
@@ -25,9 +25,9 @@ def self.decompress(source)
end
# Compresses a string using gzip.
- def self.compress(source)
@frodsan

frodsan Oct 26, 2012

Contributor

Please, can you add docs about the new options? Thanks.

Member

steveklabnik commented Nov 28, 2012

/cc @pixeltrix @fxn, what do you guys think about this?

Owner

fxn commented Dec 3, 2012

Looks good to me, the signature of the method shown by RDoc will be enough documentation for those parameters I believe, since they match gzip jargon and are self-explanatory.

We would need a CHANGELOG entry though.

Owner

pixeltrix commented Dec 3, 2012

Ditto to what @fxn said - also squash the commits please.

Owner

fxn commented Dec 8, 2012

Hi @beyond a CHANGELOG entry and commits squash is all we need here, if you find a minute we'll apply.

Contributor

beyond commented Jan 10, 2013

Hi @fxn I wrote a CHANGELOG and squashed commits.

Owner

fxn commented Feb 8, 2013

Hi @beyond, could you please revise this pull request? I tried pulling the branch to do the merge myself, but some changes related to engines come down for some reason.

@beyond beyond added compress options for gzip
added test for compress options of gzip

update changelog
d59a877
Contributor

beyond commented Feb 10, 2013

Hi @fxn This branch rebased the master branch and fixed conflicts.

Owner

fxn commented Feb 10, 2013

Looking good, thanks very much!

@fxn fxn added a commit that referenced this pull request Feb 10, 2013

@fxn fxn Merge pull request #7730 from beyond/gzip
added compress options for gzip
95dd699

@fxn fxn merged commit 95dd699 into rails:master Feb 10, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment