Move the CacheHelper#fragment_name_with_digest to be public #7769

Merged
merged 4 commits into from Oct 4, 2012

Conversation

Projects
None yet
3 participants
@rgarver
Contributor

rgarver commented Sep 27, 2012

Make it so custom fragment caching (eg: jbuilder) can leverage the cache_digests code.

@rgarver rgarver referenced this pull request in rails/jbuilder Sep 27, 2012

Merged

Adjust caching to use ActionView::Base#cache #67

@rafaelfranca

This comment has been minimized.

Show comment Hide comment
@rafaelfranca

rafaelfranca Sep 27, 2012

Owner

If we will go to make it public so we will need to add tests to it

Owner

rafaelfranca commented Sep 27, 2012

If we will go to make it public so we will need to add tests to it

@rafaelfranca

This comment has been minimized.

Show comment Hide comment
@rafaelfranca

rafaelfranca Sep 27, 2012

Owner

Documentation too.

Owner

rafaelfranca commented Sep 27, 2012

Documentation too.

@@ -113,6 +113,17 @@ def cache(name = {}, options = nil, &block)
nil
end

This comment has been minimized.

Show comment Hide comment
@dhh

dhh Oct 4, 2012

Owner

Add a #:nodoc: here. We need it public for integration purposes but otherwise it's not of general interest.

@dhh

dhh Oct 4, 2012

Owner

Add a #:nodoc: here. We need it public for integration purposes but otherwise it's not of general interest.

dhh added a commit that referenced this pull request Oct 4, 2012

Merge pull request #7769 from rgarver/feature/public-fragment_name_wi…
…th_digest

Move the CacheHelper#fragment_name_with_digest to be public

@dhh dhh merged commit c0a182d into rails:master Oct 4, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment