Make Rails.public_path return a Pathname #7825

Merged
merged 1 commit into from Oct 3, 2012

Conversation

Projects
None yet
3 participants
@sikachu
Member

sikachu commented Oct 3, 2012

I've discussed with @tenderlove earlier, and it seems like it make sense to make Rails.public_path a Pathname, so you can call Pathname methods on it, such as .join. I think this is a useful addition to this method.

@schneems

This comment has been minimized.

Show comment
Hide comment
@schneems

schneems Oct 3, 2012

Member

👍 looks useful, and seems like Pathname behaves as a string in most circumstances so backwards compatibility wouldn't be an issue.

Member

schneems commented Oct 3, 2012

👍 looks useful, and seems like Pathname behaves as a string in most circumstances so backwards compatibility wouldn't be an issue.

rafaelfranca added a commit that referenced this pull request Oct 3, 2012

Merge pull request #7825 from sikachu/master-rails-pathname
Make Rails.public_path return a Pathname

@rafaelfranca rafaelfranca merged commit 6b802cd into rails:master Oct 3, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment