Make .validators_on accept :kind option
#7826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| # => [#<ActiveModel::Validations::PresenceValidator:0x007fe604914e60 @attributes=[:name], @options={}>, | ||
| # #<ActiveModel::Validations::InclusionValidator:0x007fe603bb8780 @attributes=[:age], @options={:in=>0..99}>] | ||
|
|
||
| Person.validators_on(:name, :presence) |
This will filter out the validators on a particular attribute based on its kind.
|
Pull request updated. |
|
This will be useful ❤️ |
rafaelfranca
added a commit
that referenced
this pull request
Oct 3, 2012
Make `.validators_on` accept `:kind` option
rafaelfranca
added a commit
that referenced
this pull request
Oct 3, 2012
This reverts commit 4e9f53f, reversing changes made to 6b802cd. Revert "Don't use tap in this case." This reverts commit 454d820. Reason: Is not a good idea to add options to this method since we can do the same thing using method composition. Person.validators_on(:name).select { |v| v.kind == :presence } Also it avoids to change the method again to add more options.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Making
ActiveModel::Validators#validators_onto accept a:kindoption which will filter out the validators on a particular attribute based on its kind.