postgres, quote table names when fetching the primary key (#5920) #7850

Merged
merged 1 commit into from Oct 6, 2012

Conversation

Projects
None yet
2 participants
@senny
Member

senny commented Oct 4, 2012

quote the table name when fetching the primary key information for a postgres table.

@senny

This comment has been minimized.

Show comment
Hide comment
@senny

senny Oct 4, 2012

Member

@steveklabnik I quoted the table name to fetch the primary key information.

@tenderlove I did not search for other occurrences where the table name appears unquoted. Do you think this patch is enough to get AR working with capital letter tables?

Member

senny commented Oct 4, 2012

@steveklabnik I quoted the table name to fetch the primary key information.

@tenderlove I did not search for other occurrences where the table name appears unquoted. Do you think this patch is enough to get AR working with capital letter tables?

@rafaelfranca

This comment has been minimized.

Show comment
Hide comment
@rafaelfranca

rafaelfranca Oct 4, 2012

Member

I think is enough.

Could you change the commit message to:

PostgreSQL, quote table names when fetching the primary key. Closes #5920
Member

rafaelfranca commented Oct 4, 2012

I think is enough.

Could you change the commit message to:

PostgreSQL, quote table names when fetching the primary key. Closes #5920
@senny

This comment has been minimized.

Show comment
Hide comment
@senny

senny Oct 5, 2012

Member

@rafaelfranca the commit message is updated and the branch is rebased.

Member

senny commented Oct 5, 2012

@rafaelfranca the commit message is updated and the branch is rebased.

rafaelfranca added a commit that referenced this pull request Oct 6, 2012

Merge pull request #7850 from senny/5920_postgres_adapter_table_with_…
…capital_letters

postgres, quote table names when fetching the primary key (#5920)

@rafaelfranca rafaelfranca merged commit 9b496d3 into rails:master Oct 6, 2012

@rafaelfranca

This comment has been minimized.

Show comment
Hide comment
@rafaelfranca

rafaelfranca Oct 6, 2012

Member

Thanks

Member

rafaelfranca commented Oct 6, 2012

Thanks

rafaelfranca added a commit that referenced this pull request Oct 6, 2012

Merge pull request #7850 from senny/5920_postgres_adapter_table_with_…
…capital_letters

postgres, quote table names when fetching the primary key (#5920)
Conflicts:
	activerecord/CHANGELOG.md
	activerecord/lib/active_record/connection_adapters/postgresql/schema_statements.rb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment