Moving locale stuff from app.rb to an initializer. #7873

Merged
merged 1 commit into from Oct 8, 2012

3 participants

@steveklabnik
Ruby on Rails member

As requested by @dhh.

@dhh dhh merged commit 43e14f8 into rails:master Oct 8, 2012
@vijaydev
Ruby on Rails member

@steveklabnik Hey, will you be able to skim the guides once to see if we explicitly mention the location of these configs as 'application.rb' anywhere?

@steveklabnik
Ruby on Rails member

@vijaydev yes, I will do that now.

@steveklabnik
Ruby on Rails member
@carlosantoniodasilva carlosantoniodasilva added a commit to carlosantoniodasilva/rails that referenced this pull request Jan 22, 2013
@carlosantoniodasilva carlosantoniodasilva Revert "Merge pull request #7873 from steveklabnik/update_initializer"
This reverts commit 43e14f8, reversing
changes made to bb17a0f.

Conflicts:
	railties/lib/rails/generators/rails/app/templates/config/application.rb
	railties/lib/rails/generators/rails/app/templates/config/initializers/locale.rb

Reason: setting the Time.zone in an after_initialize block can become a
problem for people upgrading, since it's not going to be available when
config/initializers run, and people might be relying on it.

An example that I noticed was with the Chronic gem, for date/time parsing.
It requires us to configure the time class to be Time.zone, and doing
that in an initializer no longer worked with these changes, so reverting
is the safer path for now.
6fcdcfe
@tenderlove tenderlove added a commit that referenced this pull request Jan 22, 2013
@tenderlove tenderlove Merge branch 'master' into jobs
* master:
  Less strict activerecord-deprecated_finders version
  Revert "Round usec when writing timestamp attribute."
  Add failing test case for #8460
  Lets kepp using Ruby 1.9 syntax
  Only check for unpermmited parameters if action_on_unpermitted_parameters is present
  Revert "Merge pull request #7873 from steveklabnik/update_initializer"
  Revert "Set the default timezone after the initialization since the configuration"
  Revert "updating i18n guide with locale config location."
  avoid creating an object in every call
  Remove unnecessary require
  Re-do Getting Started application with Rails 4.
  fixing link to validations guide in getting started guide
  Getting Started Guide: strong_parameters
  Fix images in getting started guide.
  Remove tabs, use spaces ✂️
  Whitespaces ✂️
f0f146d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment