remove unused `expand_range_bind_variables` method #7875

Merged
merged 1 commit into from Oct 8, 2012

Projects

None yet

3 participants

@senny
Owner
senny commented Oct 8, 2012

this method was not used, not documented and not tested.

While I was looking through the code to implement #6984 I found that this method seems to have lost it's purpose.

@senny senny remove unused `expand_range_bind_variables` method
this method was not used, not documented and not tested.
13206cc
Owner
senny commented Oct 8, 2012

@rafaelfranca @steveklabnik do you know of any usage for this method? I think we can drop it since it's not used anywhere.

Owner

Right. The last usage of this method was removed at 77c23b2

@rafaelfranca rafaelfranca merged commit a9bf3a4 into rails:master Oct 8, 2012
Owner
senny commented Oct 8, 2012

@rafaelfranca thanks for the immediate response :)

gucki commented Jan 7, 2013

@senny Did you also implement #6984? :)

Owner
senny commented Jan 7, 2013

@gucki I did not yet finish that... let me check my local branch. My vague memory is that there was something holding me back from finishing this feature.

Owner
senny commented Jan 7, 2013

@gucki I checked again and the issue is, that the complete Sanitization currently is on the ActiveRecord::Base level. execute however is one level deeper on the connection. At the time I did not think the necessary refactoring was justified by this feature.

gucki commented Jan 15, 2013

@senny Thanks for the info. Imo it might be a good idea to refactor this anyway, as it doesn't really belong to ActiveRecord::Base but to the connection, don't you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment