Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

assert_template works when the same partial was rendered multiple times #7886

Merged
merged 2 commits into from Oct 11, 2012

Conversation

Projects
None yet
2 participants
Member

senny commented Oct 9, 2012

This is a fix for #3675.

I also refactored the ActionView::TestCase internals, so that a separate object keeps track of rendered views and their locals. The internal instance variable @locals does no longer exist.

Member

senny commented Oct 9, 2012

@steveklabnik @rafaelfranca this fixes #3675 I also did a refactoring because the @locals variable got fairly complex . I intentionally added separate commits so that you an have a look at the version before the refactoring. Let me know if you want to merge it in so that I can squash the commits.

Owner

rafaelfranca commented Oct 11, 2012

Seems good to me. I would squash the frist three commits.

Please rebase this pull request.

senny added some commits Oct 8, 2012

refactor `ActionView::TestCase` internals to track rendered locals
this refactoring extracts the semi complex data structure of rendered locals
per view into into a separate class
Member

senny commented Oct 11, 2012

@rafaelfranca squashed and rebased.

rafaelfranca added a commit that referenced this pull request Oct 11, 2012

Merge pull request #7886 from senny/3675_assert_template_twice_agains…
…t_same_partial

assert_template works when the same partial was rendered multiple times

@rafaelfranca rafaelfranca merged commit 888a7a5 into rails:master Oct 11, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment