warning removed: shadowing outer local variable - value #7919

Merged
merged 1 commit into from Oct 12, 2012

Conversation

Projects
None yet
3 participants
@arunagw
Member

arunagw commented Oct 12, 2012

No description provided.

rafaelfranca added a commit that referenced this pull request Oct 12, 2012

Merge pull request #7919 from arunagw/warning_removed_shadowing
warning removed: shadowing outer local variable - value

@rafaelfranca rafaelfranca merged commit 1957687 into rails:master Oct 12, 2012

@rafaelfranca

This comment has been minimized.

Show comment
Hide comment
@rafaelfranca

rafaelfranca Oct 12, 2012

Member

Thanks

Member

rafaelfranca commented Oct 12, 2012

Thanks

@spastorino

This comment has been minimized.

Show comment
Hide comment
@spastorino

spastorino Oct 12, 2012

Member

if value shadows an outer local variable I would change the name to something else meaningful instead of appending a _

Member

spastorino commented Oct 12, 2012

if value shadows an outer local variable I would change the name to something else meaningful instead of appending a _

@rafaelfranca

This comment has been minimized.

Show comment
Hide comment
@rafaelfranca

rafaelfranca Oct 12, 2012

Member

I could not think in anything better than value. Maybe is better to change the name of the block variable inside the each

Member

rafaelfranca commented Oct 12, 2012

I could not think in anything better than value. Maybe is better to change the name of the block variable inside the each

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment