Just a little pull request that use 1.9 Hash syntax for railties. I have not made these changes to the test directory. Do I should ? If I should edit something else, please let me know.
By the way, all the tests are green.
Have a nice day.
Since this is an internal syntax change, it doesn't need a changelog entry.
Okay, sorry. ^^
We've avoided changing all hash syntax since it breaks other pull requests, but maybe it's time! Could you update the tests as well?
@jeremy : I will do. In the same time, I allow myself to update Hash syntax in ActionPack (I will open another pull request for that).
@jeremy : Changelog entry removed, tests' Hash syntax changed, rebased and pushed ! 😄
Use Ruby 1.9 Hash syntax in railties
Merge pull request #7941 from robin850/master
Use 1.9 Hash syntax in railties
Thanks @jeremy ❤️
Fix typo in #7941
I was just wondering if this change should be limited to Railties, or if it can be applied to the whole Rails codebase.
In other words, would this kind of commit be accepted today? #4691 (comment)
No, and the reason is still the same. We applied only to Action Mailer and Railties because the number of open pull requests is very low. But we don't want to do the same with Active Record and Action Pack
awesome stuff... :-)