Use 1.9 Hash syntax in railties #7941

Merged
merged 1 commit into from Oct 14, 2012

Conversation

Projects
None yet
5 participants
Member

robin850 commented Oct 14, 2012

Hello,

Just a little pull request that use 1.9 Hash syntax for railties. I have not made these changes to the test directory. Do I should ? If I should edit something else, please let me know.

By the way, all the tests are green.

Have a nice day.

@jeremy jeremy and 1 other commented on an outdated diff Oct 14, 2012

railties/CHANGELOG.md
@@ -1,5 +1,7 @@
## Rails 4.0.0 (unreleased) ##
+* Use Ruby 1.9 Hash syntax in railties.
@jeremy

jeremy Oct 14, 2012

Owner

Since this is an internal syntax change, it doesn't need a changelog entry.

@robin850

robin850 Oct 14, 2012

Member

Okay, sorry. ^^

Owner

jeremy commented Oct 14, 2012

We've avoided changing all hash syntax since it breaks other pull requests, but maybe it's time! Could you update the tests as well?

Member

robin850 commented Oct 14, 2012

@jeremy : I will do. In the same time, I allow myself to update Hash syntax in ActionPack (I will open another pull request for that).

Member

robin850 commented Oct 14, 2012

@jeremy : Changelog entry removed, tests' Hash syntax changed, rebased and pushed ! 😄

@jeremy jeremy added a commit that referenced this pull request Oct 14, 2012

@jeremy jeremy Merge pull request #7941 from robin850/master
Use 1.9 Hash syntax in railties
6338e1e

@jeremy jeremy merged commit 6338e1e into rails:master Oct 14, 2012

Member

robin850 commented Oct 14, 2012

Thanks @jeremy ❤️

@jeremy jeremy added a commit that referenced this pull request Oct 14, 2012

@jeremy jeremy Fix typo in #7941 4e8cf43
Member

claudiob commented on 5ad7f8a Oct 15, 2012

I was just wondering if this change should be limited to Railties, or if it can be applied to the whole Rails codebase.
In other words, would this kind of commit be accepted today? #4691 (comment)

Owner

rafaelfranca replied Oct 15, 2012

No, and the reason is still the same. We applied only to Action Mailer and Railties because the number of open pull requests is very low. But we don't want to do the same with Active Record and Action Pack

Member

claudiob replied Oct 15, 2012

Fair enough

awesome stuff... :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment