Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Fix typo in inet and cidr saving #7942

Merged
merged 1 commit into from Oct 14, 2012

Conversation

Projects
None yet
4 participants
Contributor

IPGlider commented Oct 14, 2012

Before this commit when saving or creating a model with an inet or cidr attribute I got the error:

NoMethodError: undefined method `includes?' for ["inet", "cidr"]:Array
Member

vijaydev commented Oct 14, 2012

Can you give a failing test for this?

Contributor

IPGlider commented Oct 14, 2012

@vijaydev I can make a test, but it may require some time because I have never done one before for rails-core.

Anyway

Array#includes?

does not exists and

Array#include?

exists, is a very simple fix.

Owner

jeremy commented Oct 14, 2012

Simple fix - all the more reason for a test :)

Contributor

IPGlider commented Oct 14, 2012

@vijaydev @jeremy Tests added. If this is not enough just tell me.

Owner

rafaelfranca commented Oct 14, 2012

Could you squash your commits?

Contributor

IPGlider commented Oct 14, 2012

@rafaelfranca Should I squash and force push to my repo?

Owner

rafaelfranca commented Oct 14, 2012

Yes, github will update this same pull request.

rafaelfranca added a commit that referenced this pull request Oct 14, 2012

Merge pull request #7942 from IPGlider/master
Fix typo in inet and cidr saving

@rafaelfranca rafaelfranca merged commit ae61c03 into rails:master Oct 14, 2012

Owner

rafaelfranca commented Oct 14, 2012

@IPGlider thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment