Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Revert "truncate debug.log on each test run" #7996

Merged
merged 1 commit into from

2 participants

@yahonda

This reverts commit 98043c6. See #7994 .

Because if every time debug.log is truncated, developers have no way to see the previous ActiveRecord unit test results.

debug.log file size can be easily reduced by executing $ touch /dev/null > debug.log periodically.

@yahonda yahonda Revert "truncate debug.log on each test run"
This reverts commit 98043c6.

Because if every time `debug.log` is truncated,
developers have no way to see the previous ActiveRecord unit test results.
`debug.log` file can be easily reduced
by executing `$ touch /dev/null > debug.log` periodically.
048866a
@rafaelfranca rafaelfranca merged commit 86df55e into rails:master
@yahonda

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Oct 19, 2012
  1. @yahonda

    Revert "truncate debug.log on each test run"

    yahonda authored
    This reverts commit 98043c6.
    
    Because if every time `debug.log` is truncated,
    developers have no way to see the previous ActiveRecord unit test results.
    `debug.log` file can be easily reduced
    by executing `$ touch /dev/null > debug.log` periodically.
This page is out of date. Refresh to see the latest.
Showing with 1 addition and 2 deletions.
  1. +1 −2  activerecord/test/support/connection.rb
View
3  activerecord/test/support/connection.rb
@@ -13,8 +13,7 @@ def self.connection_config
def self.connect
puts "Using #{connection_name}"
- file = File.open('debug.log', 'w')
- ActiveRecord::Model.logger = ActiveSupport::Logger.new(file)
+ ActiveRecord::Model.logger = ActiveSupport::Logger.new("debug.log")
ActiveRecord::Model.configurations = connection_config
ActiveRecord::Model.establish_connection 'arunit'
ARUnit2Model.establish_connection 'arunit2'
Something went wrong with that request. Please try again.