Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Add i18n scope to disance_of_time_in_words. #7997

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
4 participants
Member

steveklabnik commented Oct 19, 2012

This fixes #733.

Because of the spotty wifi in RubyConfAR, I couldn't get bundle going, and so I couldn't run the tests. I wanted to get this up here, though, and @clemenshelm says that it works fine in their application.

Owner

rafaelfranca commented Oct 19, 2012

Ok. I'll run the tests and merge this one.

@rafaelfranca rafaelfranca added a commit that referenced this pull request Oct 19, 2012

@rafaelfranca rafaelfranca Merge pull request #7997 from steveklabnik/issue_733
Add i18n scope to disance_of_time_in_words.
c50de96
Owner

rafaelfranca commented Oct 19, 2012

Done

Member

steveklabnik commented Oct 20, 2012

❤️ ❤️ ❤️

APIs being down are annoying.

Owner

steveklabnik replied Oct 20, 2012

hmmm on github it's wrong, but on my local copy, it's right

Contributor

clemens commented Nov 26, 2012

Will this only be in Rails 4 or will there be a backport to Rails 3.2.x? Would be great to have it in 3-2-stable and then also 3.2.10 ...

Member

steveklabnik commented Nov 26, 2012

Backported here: #8321

@steveklabnik steveklabnik added a commit to steveklabnik/rails that referenced this pull request Nov 26, 2012

@steveklabnik steveklabnik Add i18n scope to disance_of_time_in_words.
This is a backport of rails/rails#7997.
1a876f6

@steveklabnik steveklabnik added a commit to steveklabnik/rails that referenced this pull request Nov 26, 2012

@steveklabnik steveklabnik Add changelog for #7997.
This was forgotten when we did the merge.
512a8c7

@rafaelfranca rafaelfranca added a commit that referenced this pull request Nov 26, 2012

@rafaelfranca rafaelfranca Merge pull request #8323 from steveklabnik/changelog_7997
Add changelog for #7997.
586bc59
Contributor

clemens commented Mar 18, 2013

Question: Should we also add this to time_ago_in_words – maybe even with a different scope (e.g. datetime.time_ago_in_words)? I'm happy to prepare and submit a PR ...

Member

steveklabnik commented Mar 18, 2013

Yes, let's give it a try with a PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment