remove trailing whitespace within actionpack #8043

Merged
merged 1 commit into from Oct 27, 2012

2 participants

@senny
Ruby on Rails member

I've been browsing the actionpack source lately and submitted a few patches.
There were occasions of trailing whitespace and to keep the commit diffs clean,
I removed them all in one go.

@senny
Ruby on Rails member

@rafaelfranca this is just cleanup stuff. I really don't like trailing whitespace. If you agree I'll also remove the whitespace in other parts of rails.

@rafaelfranca
Ruby on Rails member

I agree that we need to clean this but I think is not a good idea do this to entire framework because can invalidate some pull requests. However I'll merge this one

Thank you

@rafaelfranca rafaelfranca merged commit f3807a8 into rails:master Oct 27, 2012
@senny
Ruby on Rails member

@rafaelfranca what is your prefered way of cleaning them? adding a separate commit to PR which, touch a file that has trailing whitespace? include the trailing whitespace removal in the patch-commit?

@rafaelfranca
Ruby on Rails member

I always do in a separate commit to PR which touch a file that has trailing whitespaces. see 623f2fb

@senny
Ruby on Rails member

thanks, now I know ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment