New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove trailing whitespace within actionpack #8043

Merged
merged 1 commit into from Oct 27, 2012

Conversation

Projects
None yet
2 participants
@senny
Member

senny commented Oct 27, 2012

I've been browsing the actionpack source lately and submitted a few patches.
There were occasions of trailing whitespace and to keep the commit diffs clean,
I removed them all in one go.

@senny

This comment has been minimized.

Member

senny commented Oct 27, 2012

@rafaelfranca this is just cleanup stuff. I really don't like trailing whitespace. If you agree I'll also remove the whitespace in other parts of rails.

@rafaelfranca

This comment has been minimized.

Member

rafaelfranca commented Oct 27, 2012

I agree that we need to clean this but I think is not a good idea do this to entire framework because can invalidate some pull requests. However I'll merge this one

Thank you

rafaelfranca added a commit that referenced this pull request Oct 27, 2012

Merge pull request #8043 from senny/remove_trailing_whitespace_in_act…
…ionpack

remove trailing whitespace within actionpack [ci skip]

@rafaelfranca rafaelfranca merged commit f3807a8 into rails:master Oct 27, 2012

@senny

This comment has been minimized.

Member

senny commented Oct 27, 2012

@rafaelfranca what is your prefered way of cleaning them? adding a separate commit to PR which, touch a file that has trailing whitespace? include the trailing whitespace removal in the patch-commit?

@rafaelfranca

This comment has been minimized.

Member

rafaelfranca commented Oct 27, 2012

I always do in a separate commit to PR which touch a file that has trailing whitespaces. see 623f2fb

@senny

This comment has been minimized.

Member

senny commented Oct 27, 2012

thanks, now I know ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment