Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Removing JSON for other ruby #8047

Merged
merged 1 commit into from

5 participants

@arunagw
Collaborator

It's only required for 1.8 and for JRuby!
I was fixing a bug with JSON pure on 1.8.7
and I found that we have included json for other
1.8 > rubies also.

@arunagw arunagw Removing JSON for other ruby
It's only required for 1.8 and for JRuby!
I was fixing a bug with JSON pure on 1.8.7
and I found that we have included json for other
1.8 > rubies also.
1adb784
@carlosantoniodasilva

Hey mate, not sure I got what you are trying to explain. We don't need the json gem for Ruby 1.9 you say?

@steveklabnik
Collaborator

Yes, you do not:

steve at thoth in ~
$ irb
requi1.9.3p194 :001 > require 'json'
 => true 
1.9.3p194 :002 > RUBY_VERSION
 => "1.9.3" 
@carlosantoniodasilva

So the question is: should we stick with the impl that comes with ruby, or use the gem that can be updated if necessary?

@arunagw
Collaborator

I think this is question that we need to decide. I can confirm in a while if tests are running fine.

What you say?

@arunagw
Collaborator

All Green on this branch.

@steveklabnik
Collaborator

IIRC, @evanphx explained to me that the json gem does the right thing nowadays with all rubies; I took multi_json out of resque because of this. I don't think that we need anything specific, and if we need to 'update if necessary' we can just add it back then.

@tenderlove
Owner

@carlosantoniodasilva the JSON gem ships with ruby, people can still update the gem after installing ruby.

It should be safe to apply this patch.

@rafaelfranca

Yes, it should be fine. But we will have json installed because rdoc and w3c_validators have it as dependency.

@carlosantoniodasilva

@rafaelfranca yes, I noticed that.

@tenderlove ok, thanks for clarifying.

@carlosantoniodasilva carlosantoniodasilva merged commit 2b5d3aa into from
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Oct 28, 2012
  1. @arunagw

    Removing JSON for other ruby

    arunagw authored
    It's only required for 1.8 and for JRuby!
    I was fixing a bug with JSON pure on 1.8.7
    and I found that we have included json for other
    1.8 > rubies also.
This page is out of date. Refresh to see the latest.
Showing with 0 additions and 1 deletion.
  1. +0 −1  Gemfile
View
1  Gemfile
@@ -52,7 +52,6 @@ platforms :mri do
end
platforms :ruby do
- gem 'json'
gem 'yajl-ruby'
gem 'nokogiri', '>= 1.4.5'
Something went wrong with that request. Please try again.