Provide a call stack for deprecation warnings where needed. #8063

Merged
merged 1 commit into from Oct 29, 2012

4 participants

@nikitug

It's sometimes hard to quickly find where deprecated call was performed, especially in case of migrating between Rails versions. So this is an attempt to improve the call stack part of the warning message by providing caller explicitly.

@nikitug nikitug Provide a call stack for deprecation warnings where needed.
It's sometimes hard to quickly find where deprecated call was performed, especially in case of migrating between Rails versions. So this is an attempt to improve the call stack part of the warning message by providing caller explicitly.
0b7067d
@carlosantoniodasilva carlosantoniodasilva merged commit d1c95d9 into rails:master Oct 29, 2012
@carlosantoniodasilva
Ruby on Rails member

Thanks.

@steveklabnik
Ruby on Rails member

Doesn't caller have a pretty big performance overhead? Even if it does, I don't know if it's enough to matter. Just wondering.

@gazay

@carlosantoniodasilva maybe this solution will be more clear and full? #6107

@carlosantoniodasilva
Ruby on Rails member

@steveklabnik maybe we could try benchmarking it to see? Also, we hope people fix warnings as soon as they see them, killing the possible existent overhead.

@gazay perhaps, I'll check and ask someone else to do so, thanks for pointing that out!

@nikitug

@gazay @carlosantoniodasilva yep, rails/rails#6107 seems better in this case 👍

@carlosantoniodasilva
Ruby on Rails member

Merged, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment