handle trailing slash with engines (test case for #7842) #8115

Merged
merged 2 commits into from Nov 8, 2012

4 participants

@senny
Ruby on Rails member

This PR adds a test case to make sure that we don't get any regressions on #7842. Also I removed obsolete code from the _generate_prefix method.

The issue described in #7842 has been fixed on master but is still present on 3-2-stable. The attached test case will fail on 3-2-stable and passes on master.

@senny
Ruby on Rails member

I did not create a CHANGELOG entry, since I did not modify any existing functionality. Also I split the commits because they are not related to each other and adress separate concerns.

@steveklabnik @rafaelfranca can you take a look? let me know if I need to change things up.

@steveklabnik
Ruby on Rails member

Seems legit to me.

@schneems
Ruby on Rails member

I say 👍 for testing this regression, though would want this squashed into 1 commit. Anything to add @steveklabnik? @senny since the previous behavior is a bug, would you be willing to submit your fix against the 3.2 branch?

@senny
Ruby on Rails member

sure, I already did the fix for 3.2 because I thought it was still present in master.

@senny
Ruby on Rails member

@schneems I split the two commits, because the test-case can be backported and refactoring not.

@rafaelfranca what do you think?

@rafaelfranca rafaelfranca merged commit 3148ed9 into rails:master Nov 8, 2012
@schneems
Ruby on Rails member

Thanks for your work @senny.

@senny senny added a commit to senny/rails that referenced this pull request Nov 8, 2012
@senny senny backport, handle trailing slash with engines
this is a backport of #8115 to fix #7842
d12e753
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment