Skip to content

Add app Rake tasks when -T and --dummy-path is passed to `plugin new` #8139

Merged
merged 1 commit into from Nov 8, 2012

3 participants

@senny
Ruby on Rails member
senny commented Nov 7, 2012

This patch adds the dummy app Rake tasks to the Rakefile template when rails plugin new is called with --skip-test-unit and --dummy-path. Since --dummy-path generates the dummy app even when test unit is skipped I think it's ok to also add in the Rake tasks.

I added a CHANGELOG entry and also created the with_dummy_app? method to reuse the condition.

This is a fix for #8121

@senny
Ruby on Rails member
senny commented Nov 7, 2012

@drogus can you take a look?

@drogus
Ruby on Rails member
drogus commented Nov 7, 2012

I'm nitpicking ;), but could you format commit message as described here: http://guides.rubyonrails.org/contributing_to_ruby_on_rails.html#commit-your-changes ?

Other than that, it's cool.

@senny
Ruby on Rails member
senny commented Nov 8, 2012

I've read the description in the guide before but I think I forgot because most commit messages in rails don't follow the 50 character limit :) I'll stick to it from now on.

@drogus thanks for the feedback. I've updated the messages.

@carlosantoniodasilva
Ruby on Rails member

Yeah, the 50 char limit is kinda hard to follow all the time, but I try to at least describe the most I can when I think it's necessary.

@senny this looks good, can you please squash? Thanks!

@drogus
Ruby on Rails member
drogus commented Nov 8, 2012

@senny yeah, 50 char is tough, but it's not some hard limit, if you go up a little it does not change too much - I just don't like when it's longer than 72, as then it needs to be wrapped on github and starts to be less readable in git log with --oneline

@senny senny `plugin new` adds dummy app tasks when necessary.
Closes #8121

The `plugin new` generator always adds the dummy app rake tasks,
when a dummy app was created.
1785bf7
@senny
Ruby on Rails member
senny commented Nov 8, 2012

@carlosantoniodasilva commits are squashed... (I created separate commits because of the discussion #8043 with @rafaelfranca and I think it makes backporting easier when no random conflicts appear, which are not related.)

Thanks for the inputs regarding commit messages. I think 72 as a hard limit and 50 as a soft limit is reasonable.

@carlosantoniodasilva
Ruby on Rails member

@senny alright, no problem. In this particular case I thought it was not necessary since it was just a minor space in the changelog, which is hardly ever changed - thus conflicts shouldn't be a problem. Thanks!

👍 for the commit messages.

@carlosantoniodasilva carlosantoniodasilva merged commit 9abec81 into rails:master Nov 8, 2012
@senny senny added a commit to senny/rails that referenced this pull request Nov 15, 2012
@senny senny backport #8139, `plugin new` adds dummy app tasks when necessary. …
The `plugin new` generator always adds the dummy app rake tasks,
when a dummy app was created.

Closes #8224

Conflicts:

	railties/CHANGELOG.md
e69058c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.