Add note about squashing in contributor guide. #8152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do we want to add a paragraph about the justification for squashing? Easier to revert, cleaner git history etc. |
|
Sure. I'll add it and then squash the two commits together. ;) |
We tell people how to do this all the time in the Issues tracker, so now we can just point them here.
|
Awesome! Authorship looks good, I think the contrib app is going to credit you both automatically. |
|
Updated! |
fxn
added a commit
that referenced
this pull request
Nov 9, 2012
Add note about squashing in contributor guide.
|
@fxn yep! it credited both of us. |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
We tell people how to do this all the time in the Issues tracker,
so now we can just point them here.
This is a first commit pairing by @kytrinyx and I, so @fxn, can you check the authorship and make sure it makes sense?