Fix for inflector's incorrect camelCase replacement for acronyms #8156

Merged
merged 2 commits into from Mar 16, 2013

Conversation

Projects
None yet
5 participants
@fredwu
Contributor

fredwu commented Nov 9, 2012

Description of this bug: #8015

@fredwu

This comment has been minimized.

Show comment
Hide comment
@fredwu

fredwu Nov 9, 2012

Contributor

PR for 3.2 branch: #8155

Contributor

fredwu commented Nov 9, 2012

PR for 3.2 branch: #8155

@steveklabnik

This comment has been minimized.

Show comment
Hide comment
@steveklabnik

steveklabnik Nov 9, 2012

Member

/cc @fxn

Member

steveklabnik commented Nov 9, 2012

/cc @fxn

@fredwu

This comment has been minimized.

Show comment
Hide comment
@fredwu

fredwu Mar 6, 2013

Contributor

Hi @fxn, would you mind taking a look at this PR as it's been quite a while and it'd be awesome if this is going to get addressed. :)

Contributor

fredwu commented Mar 6, 2013

Hi @fxn, would you mind taking a look at this PR as it's been quite a while and it'd be awesome if this is going to get addressed. :)

@fxn

This comment has been minimized.

Show comment
Hide comment
@fxn

fxn Mar 16, 2013

Member

Can you please rebase this one? We'll apply.

Member

fxn commented Mar 16, 2013

Can you please rebase this one? We'll apply.

@fredwu

This comment has been minimized.

Show comment
Hide comment
@fredwu

fredwu Mar 16, 2013

Contributor

Thanks @fxn , rebased!

Contributor

fredwu commented Mar 16, 2013

Thanks @fxn , rebased!

@lukaszx0

This comment has been minimized.

Show comment
Hide comment
@lukaszx0

lukaszx0 Mar 16, 2013

Member

Awesome! Thanks @fredwu and @fxn

🤘

Member

lukaszx0 commented Mar 16, 2013

Awesome! Thanks @fredwu and @fxn

🤘

fxn added a commit that referenced this pull request Mar 16, 2013

Merge pull request #8156 from fredwu/acronym_fix-master
Fix for inflector's incorrect camelCase replacement for acronyms

@fxn fxn merged commit 867dc17 into rails:master Mar 16, 2013

@MacksMind

This comment has been minimized.

Show comment
Hide comment
@MacksMind

MacksMind Mar 16, 2013

Contributor

This caused breakage in actionpack/test/controller/force_ssl_test.rb, and will likely break production apps as well. Controllers such as ForceSSLOnlyAction now have a path of /force_sslonly_action when previously it would have been /force_ssl_only_action.

Contributor

MacksMind commented Mar 16, 2013

This caused breakage in actionpack/test/controller/force_ssl_test.rb, and will likely break production apps as well. Controllers such as ForceSSLOnlyAction now have a path of /force_sslonly_action when previously it would have been /force_ssl_only_action.

@steveklabnik

This comment has been minimized.

Show comment
Hide comment
@steveklabnik

steveklabnik Mar 16, 2013

Member

@MacksMind you are awesome. I started getting errors on the rails-api build for this exact situation, and hadn't found the time to track it down.

Member

steveklabnik commented Mar 16, 2013

@MacksMind you are awesome. I started getting errors on the rails-api build for this exact situation, and hadn't found the time to track it down.

@fxn

This comment has been minimized.

Show comment
Hide comment
@fxn

fxn Mar 16, 2013

Member

Have to be reverted then, the example reported in the original PR needs a fix, but the patch is not good.

I am out though, Steve could you revert please?

Member

fxn commented Mar 16, 2013

Have to be reverted then, the example reported in the original PR needs a fix, but the patch is not good.

I am out though, Steve could you revert please?

@steveklabnik

This comment has been minimized.

Show comment
Hide comment
@steveklabnik

steveklabnik Mar 16, 2013

Member

Yes.

Member

steveklabnik commented Mar 16, 2013

Yes.

steveklabnik added a commit that referenced this pull request Mar 16, 2013

Revert "Merge pull request #8156 from fredwu/acronym_fix-master"
This reverts commit 867dc17, reversing
changes made to 9a421aa.

This breaks anyone who's using ForceSSL: https://travis-ci.org/rails-api/rails-api/jobs/5556065

Please see comments on #8156 for some discussion.
@steveklabnik

This comment has been minimized.

Show comment
Hide comment
@steveklabnik

steveklabnik Mar 16, 2013

Member

Reveted in feaa6e2

Member

steveklabnik commented Mar 16, 2013

Reveted in feaa6e2

@fxn

This comment has been minimized.

Show comment
Hide comment
@fxn

fxn Mar 16, 2013

Member

Thanks!

Member

fxn commented Mar 16, 2013

Thanks!

@fredwu

This comment has been minimized.

Show comment
Hide comment
@fredwu

fredwu Mar 17, 2013

Contributor

I'm taking a look at this and will fix my patch.

Contributor

fredwu commented Mar 17, 2013

I'm taking a look at this and will fix my patch.

fredwu added a commit to fredwu/rails that referenced this pull request Mar 17, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment