Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

render every partial with a new `PartialRenderer`. #8212

Merged
merged 1 commit into from Nov 19, 2012

Conversation

Projects
None yet
3 participants
Member

senny commented Nov 13, 2012

This resolves issues when rendering nested partials.
Previously the PartialRenderer was reused which led to
situations where the state of the renderer was reset.

Closes #8197

Member

senny commented Nov 13, 2012

I would like to backport this because we faced issues related to nested rendering.

@josevalim what do you think?

Might be a bit risky to backport? Dunno

Contributor

josevalim commented Nov 19, 2012

Can we also remove the memoization from the template renderer too please?

@senny senny render every partial with a new `PartialRenderer`.
This resolves issues when rendering nested partials.
Previously the `PartialRenderer` was reused which led to
situations where the state of the renderer was reset.

Closes #8197
1d07d3d

@josevalim josevalim added a commit that referenced this pull request Nov 19, 2012

@josevalim josevalim Merge pull request #8212 from senny/8197_make_render_in_spacer_templa…
…te_work

render every partial with a new `PartialRenderer`.
a1c7eae

@josevalim josevalim merged commit a1c7eae into rails:master Nov 19, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment