Use BCrypt's MIN_COST in the test environment for speedier tests #8216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
I'm :+1000: on this, can you add an entry on CHANGELOG please? Thanks |
|
Looks good to me. |
|
Also looks good to me. Hurray for faster tests! |
|
That's what we do in devise as well |
|
I force-pushed an update to include the CHANGELOG entry. Let me know if you guys would like any other changes. Thanks! |
rafaelfranca
added a commit
that referenced
this pull request
Nov 14, 2012
Use BCrypt's MIN_COST in the test environment for speedier tests
|
Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
I came across this blog post:
http://collectiveidea.com/blog/archives/2012/11/12/tests-oddly-slow-might-be-bcrypt/
...which suggests putting the following into a your
test_helper:BCrypt::Engine::DEFAULT_COST = 1...for a speedier test suite.
I tested this out on a few apps, found a noticeable speedup, and worked with @jeremy on this pull request after reviewing the feedback on this existing pull request: #285