refactor the naming within plugin new generator #8263

Merged
merged 1 commit into from Jan 6, 2013

Projects

None yet

3 participants

@senny
Member
senny commented Nov 18, 2012

Having a method called full?, which checks on :full and :mountable
is very confusing. I renamed full? to engine? and created a full?
method that only checks the :full option.

I started this work from the discussion on #8192.

@senny senny refactor the naming within plugin new generator
Having a method called `full?`, which checks on :full and :mountable
is very confusing. I renamed `full?` to `engine?` and created a `full?`
method that only checks the `:full` option
e63a97d
@senny
Member
senny commented Nov 18, 2012

@drogus can you take a look?

@drogus
Member
drogus commented Nov 20, 2012

@senny could you paste a gists of files that are generated by both options in such configuration? I would like to get feedback also from others and it will make discussion much simpler (summary of other things related to those options would be great, too)

@senny
Member
senny commented Nov 20, 2012

@drogus what content do you want inside the gist? Only the file names or the complete content?

@drogus
Member
drogus commented Nov 20, 2012

@senny filenames, otherwise it will be hard to read :)

@senny
Member
senny commented Nov 20, 2012

Here is the generator output from plugin new --full and plugin new --mountable

https://gist.github.com/4117054

@senny
Member
senny commented Dec 2, 2012

@rafaelfranca any thoughts on this one?

@wycats wycats merged commit d6c732f into rails:master Jan 6, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment