Accept symbols as #send_data :disposition value #8327

Closed
wants to merge 1 commit into
from

Projects

None yet

2 participants

@elia

Added a #to_s and the test

@carlosantoniodasilva
Ruby on Rails member

Please send your pull request to master instead, we don't usually merge things directly to 3-2, specially if they're considered new features. They'll get backported as necessary. Thanks!

@elia elia commented on the diff Nov 26, 2012
actionpack/test/controller/send_file_test.rb
@@ -138,7 +150,7 @@ def test_send_file_headers_with_bad_symbol
@controller.headers = {}
assert_raise(ArgumentError){ @controller.send(:send_file_headers!, options) }
end
-
+
@elia
elia Nov 26, 2012

This slipped into the commit, let me know if I need to (boringly) restore the spurious whitespace :)

@carlosantoniodasilva
Ruby on Rails member
@carlosantoniodasilva
Ruby on Rails member

Can you add the changelog entry to this one as well, and amend your commit? Or if you prefer I can just backport the other one, your call. Thanks!

@elia

I pushed them yesterday but since the PR is closed it doesn't update the commits list
(see https://github.com/elia/rails/tree/fix-send-data-disposition-with-symbols)

btw it's fine to backport the other one :)

@carlosantoniodasilva
Ruby on Rails member

Ah ok, thanks @elia, I'll check it later today.

@carlosantoniodasilva
Ruby on Rails member

Done, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment