Cache digest opt out cleanup #8339

Merged
merged 2 commits into from Nov 27, 2012

Conversation

Projects
None yet
2 participants
@latortuga
Contributor

latortuga commented Nov 27, 2012

Per original discussion in this thread with @carlosantoniodasilva and @rafaelfranca, I have cleaned up the CacheHelper changes and added a CHANGELOG. I couldn't figure out how to add to the closed PR so I made a new one - hope that's okay!

@rafaelfranca

This comment has been minimized.

Show comment Hide comment
@rafaelfranca

rafaelfranca Nov 27, 2012

Member

@latortuga yes, there is not way to change already merged pull request.

Thank you so much for this one. Could you squash the code change commits?

Leave one for the CHANGELOG entry and another to the changes in the code.

Member

rafaelfranca commented Nov 27, 2012

@latortuga yes, there is not way to change already merged pull request.

Thank you so much for this one. Could you squash the code change commits?

Leave one for the CHANGELOG entry and another to the changes in the code.

latortuga added some commits Nov 27, 2012

Cleanup CacheHelper changes allowing opt-out of cache digests
Instead of deleting the skip_digest option flag, this changes the method to merely check the
key. This change is because of a discussion in this thread:

#8317

This commit also makes #fragment_name_with_digest private due to its
functionality being subsumed by #cache_fragment_name.
@latortuga

This comment has been minimized.

Show comment Hide comment
@latortuga

latortuga Nov 27, 2012

Contributor

@rafaelfranca Sure thing, I squashed the code changes into one commit and rebased to current master. Thanks for the guidance!

Contributor

latortuga commented Nov 27, 2012

@rafaelfranca Sure thing, I squashed the code changes into one commit and rebased to current master. Thanks for the guidance!

rafaelfranca added a commit that referenced this pull request Nov 27, 2012

@rafaelfranca rafaelfranca merged commit 6c0ea88 into rails:master Nov 27, 2012

@rafaelfranca

This comment has been minimized.

Show comment Hide comment
@rafaelfranca

rafaelfranca Nov 27, 2012

Member

Thank you so much

Member

rafaelfranca commented Nov 27, 2012

Thank you so much

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment