Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kindle ebook generation with working section navigation #8348

Merged
merged 1 commit into from Dec 8, 2012

Conversation

danchoi
Copy link

@danchoi danchoi commented Nov 28, 2012

This commit corrects the Kindle ebook navigation to work on the Kindle Touch and other recent Kindles capable of section-by-section and periodical-style navigation.

@steveklabnik
Copy link
Member

In the future, just force-push to your branch, and the pull request will be updated.

@danchoi
Copy link
Author

danchoi commented Nov 28, 2012

Thanks for the tip. I have a lot of git to learn.

@steveklabnik
Copy link
Member

It's all good. :)

end
end

def generate_front_matter(html_pages)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we name it better? Frontmatter doesn't sound good :(

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But front matter is what this part of the book is technically called, according to Wikipedia: http://en.wikipedia.org/wiki/Book_design

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see. In that case, can you make the change to "Front matter" instead of "Frontmatter" ?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure.

@vijaydev
Copy link
Member

vijaydev commented Dec 1, 2012

Looks alright on a Fire. @danchoi Is it possible to add a cover image for the guides?

@danchoi
Copy link
Author

danchoi commented Dec 1, 2012

I'll work on that

@vijaydev
Copy link
Member

vijaydev commented Dec 1, 2012

Thanks! That'll make it look great ❤️

@danchoi
Copy link
Author

danchoi commented Dec 1, 2012

Oops. I think I need to redo this commit

@steveklabnik
Copy link
Member

@danchoi is this ready to merge? @vijaydev @fxn what do you think, can we merge this?

@danchoi
Copy link
Author

danchoi commented Dec 8, 2012

It should be good to go.

@fxn
Copy link
Member

fxn commented Dec 8, 2012

Excellent, I'll try to merge today.

@@ -0,0 +1,119 @@
#!/usr/bin/env ruby

unless `which kindlerb`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isn't this already checked in guides/Rakefile?

@vijaydev
Copy link
Member

vijaydev commented Dec 8, 2012

@danchoi This has come out very nice. Thanks a lot for working on this!

@vijaydev
Copy link
Member

vijaydev commented Dec 8, 2012

@fxn I'm merging this one.

vijaydev added a commit that referenced this pull request Dec 8, 2012
Kindle ebook generation with working section navigation
@vijaydev vijaydev merged commit 86269b4 into rails:master Dec 8, 2012
@fxn
Copy link
Member

fxn commented Dec 8, 2012

@vijaydev 🤘

@danchoi
Copy link
Author

danchoi commented Dec 8, 2012

You're welcome!

Sent from my iPhone

On Dec 8, 2012, at 1:32 PM, Vijay Dev notifications@github.com wrote:

@danchoi This has come out very nice. Thanks a lot for working on this!


Reply to this email directly or view it on GitHub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants