New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kindle ebook generation with working section navigation #8348
Conversation
|
In the future, just force-push to your branch, and the pull request will be updated. |
|
Thanks for the tip. I have a lot of git to learn. |
|
It's all good. :) |
| end | ||
| end | ||
|
|
||
| def generate_front_matter(html_pages) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we name it better? Frontmatter doesn't sound good :(
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But front matter is what this part of the book is technically called, according to Wikipedia: http://en.wikipedia.org/wiki/Book_design
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see. In that case, can you make the change to "Front matter" instead of "Frontmatter" ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure.
|
Looks alright on a Fire. @danchoi Is it possible to add a cover image for the guides? |
|
I'll work on that |
|
Thanks! That'll make it look great |
|
Oops. I think I need to redo this commit |
|
It should be good to go. |
|
Excellent, I'll try to merge today. |
| @@ -0,0 +1,119 @@ | |||
| #!/usr/bin/env ruby | |||
|
|
|||
| unless `which kindlerb` | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
isn't this already checked in guides/Rakefile?
|
@danchoi This has come out very nice. Thanks a lot for working on this! |
|
@fxn I'm merging this one. |
Kindle ebook generation with working section navigation
|
You're welcome! Sent from my iPhone On Dec 8, 2012, at 1:32 PM, Vijay Dev notifications@github.com wrote:
|
This commit corrects the Kindle ebook navigation to work on the Kindle Touch and other recent Kindles capable of section-by-section and periodical-style navigation.