Specify type of singular assication during serialization #8352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rafaelfranca I did a different refactoring than you did, mine is even simpler, I think. I used the 1.9 hash syntax, let me know if you want it in 1.8 so you can cherry-pick a backport. |
| records.to_xml(merged_options) | ||
|
|
||
| unless records.class.to_s.underscore == association.to_s | ||
| merged_options[:type] = records.class.name |
|
Why you removed all these tests? |
| assert_match %r{<address>}, xml | ||
| assert_match %r{<apt-number type="integer">}, xml | ||
| test "association with sti" do | ||
| xml = @contact.to_xml(:include => :contact) |
|
Because I suck at git. Ugh. I'll fix that now. |
| @@ -238,7 +241,6 @@ def to_ary | |||
| xml = @contact.to_xml :dasherize => false, :include => :address, :indent => 0 | |||
| assert_match %r{<apt_number type="integer">}, xml | |||
| end | |||
|
|
|||
There was a problem hiding this comment.
This line should not be removed
|
Sorry, I forgot to ask the CHANGELOG entry |
|
Doing it now. I figured I'd wait till you were happy with the patch itself. |
When serialising a class, specify the type of any singular associations, if necessary. Rails already correctly specifies the :type of any enumerable association (e.g. a has_many association), but made no attempt to do so for non-enumerables (e.g. a has_one association). We must specify the :type of any STI association. A has_one association to a class which uses single-table inheritance is an example of this type of association. Fixes rails#7471
|
Done. |
rafaelfranca
added a commit
that referenced
this pull request
Nov 28, 2012
Specify type of singular assication during serialization
|
❤️ 💚 💙 💛 💜 |
|
🤘 ❤️ |
|
Should I open a PR to backport are are you going to? |
|
Thank you guys very much for your work here. I appreciate it. |
|
Thanks for kicking it off! |
rafaelfranca
added a commit
that referenced
this pull request
Nov 29, 2012
Specify type of singular assication during serialization Conflicts: activemodel/CHANGELOG.md activemodel/test/cases/serializers/xml_serialization_test.rb
|
I already did yesterday but forget to push. Done now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When serialising a class, specify the type of any singular associations, if
necessary. Rails already correctly specifies the :type of any enumerable
association (e.g. a has_many association), but made no attempt to do so for
non-enumerables (e.g. a has_one association).
We must specify the :type of any STI association. A has_one
association to a class which uses single-table inheritance is an example of
this type of association.
Fixes #7471