Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Allow fragment cache to accept :if and :unless options #8371
referenced this pull request
Nov 29, 2012
I'll have a closer look later but it'll need a CHANGELOG entry and the commits squashing on first glance.
I didn't undertand why did you open a new pull request with the same code of #5396 without ask to the original author if it is still interested in the code.
Besides this, (both) pull requests look good and only need the CHANGELOG entry and the commits squashed.
@rafaelfranca sorry about that, I should have asked, you are right. I didn't mean to cheat anybody, I just thought it was easier for me to start from a white page on a branch of my own. And maybe I considered two months inactivity as enough time for anybody to be no longer interested in the code. Please go ahead with whatever you feel to be more correct to resolve this pull request.
@freegenie no problem. You did an awesome work and deserves recognition. Also, your tests are passing.
To be fair change you commit message and put this in the last line:
And we can merge this one.
Thank you so much for the pull request.