Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split Validations and Callbacks into separate guides. #8378

Merged

Conversation

steveklabnik
Copy link
Member

Two big features that are only barely related in the same guide. Seems
bad.

I did not check references to these guides yet, so some links may need
to be updated.

@steveklabnik
Copy link
Member Author

/cc @fxn @vijaydev

@carlosantoniodasilva
Copy link
Member

Seems a good change to me.

@richo
Copy link

richo commented Nov 29, 2012

Seems reasonable, as a user the SEO impact longer term will be noticable.

When I first starting trying to learn rails on the job with an existing codebase, there were a lot of "wat" moments when some info was buried in a seemingly unrelated page. Seems like a good step in the right direction.

@fxn
Copy link
Member

fxn commented Nov 29, 2012

👍

@rafaelfranca
Copy link
Member

👍, needs to update the guides list. https://github.com/rails/rails/blob/master/guides/source/documents.yaml

And add a Changelog entry.

Two big features that are only barely related in the same guide. Seems
bad.

I did not check references to these guides yet, so some links may need
to be updated.
rafaelfranca added a commit that referenced this pull request Nov 29, 2012
…s_guide

Split Validations and Callbacks into separate guides.
@rafaelfranca rafaelfranca merged commit 0a6afef into rails:master Nov 29, 2012
@steveklabnik
Copy link
Member Author

🤘

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants