test showing that the :digest option to CookieStore does absolutely nothing anymore #8513

Closed
wants to merge 1 commit into
from

Projects

None yet

5 participants

@yyyc514
Contributor
yyyc514 commented Dec 14, 2012

Seems this was broken 3 years ago and no one noticed?

25f7c03

Not sure how best to go about fixing it - if anyone cares? This (:digest) was a good idea, but either no one is using it or has no idea it broke - since it would be a very silent failure.

@yyyc514
Contributor
yyyc514 commented Dec 14, 2012

How would you go about fixing this without hard coding rack.sessions.options into the rails Cookies class?

@parndt
Contributor
parndt commented Feb 28, 2013

Huh, hopefully this gets reviewed before Rails 4.0

@jaggederest
Contributor

I believe this is fixed in Master, can someone confirm?

@senny
Member
senny commented Feb 13, 2014

@chancancode can you determine the status of this issue and merge / close accordingly?

@yyyc514
Contributor
yyyc514 commented Feb 27, 2014

Should be as simple and running the test suite and seeing if the test still fails.

@chancancode chancancode self-assigned this Mar 13, 2014
@chancancode
Member

@yyyc514 you are absolutely right, this has been broken since 3.0 by mistake. We should have deprecated the option back then. But since has been so long, and like you said I doubt anyone is using it, and considering how much code we will need to bring back to support this, we should just fix the doc and move on.

If someone is actually looking for a fix for this, I suppose I can help them write a gem that brings this back. Basically you'll just create a new store that uses the cookie store code before 25f7c03...

@yyyc514
Contributor
yyyc514 commented Jul 30, 2014

Works for me I guess. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment