Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

DebugExceptions `File.join` => `File.expand_path` #8529

Merged
merged 1 commit into from Dec 16, 2012

Conversation

Projects
None yet
5 participants
Member

schneems commented Dec 16, 2012

No description provided.

@josevalim josevalim and 2 others commented on an outdated diff Dec 16, 2012

...ck/lib/action_dispatch/middleware/debug_exceptions.rb
@@ -7,7 +7,7 @@ module ActionDispatch
# This middleware is responsible for logging exceptions and
# showing a debugging page in case the request is local.
class DebugExceptions
- RESCUES_TEMPLATE_PATH = File.join(File.dirname(__FILE__), 'templates')
+ RESCUES_TEMPLATE_PATH = File.extend_path('../templates' __FILE__)
@josevalim

josevalim Dec 16, 2012

Contributor

Missing a comma.

@carlosantoniodasilva

carlosantoniodasilva Dec 16, 2012

Owner

Shouldn't that be expand_path instead?

@exviva

exviva Dec 16, 2012

Contributor

Did you mean expand_path?

Member

schneems commented Dec 16, 2012

Fixed... not my finest hour. Thanks guys.

steveklabnik added a commit that referenced this pull request Dec 16, 2012

Merge pull request #8529 from schneems/schneems/debug-exceptions-exte…
…nd-path

DebugExceptions `File.join` => `File.expand_path`

@steveklabnik steveklabnik merged commit aefdcfd into rails:master Dec 16, 2012

Member

steveklabnik commented Dec 16, 2012

We all do it, man. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment