Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

deprecation warning when BufferedLogger is instantiated #8608

Merged
merged 1 commit into from Dec 25, 2012

Conversation

Projects
None yet
2 participants
Member

senny commented Dec 25, 2012

This commit belongs to a previously merged PR #8607

ActiveSupport::BufferedLogger is not only subclassed but also instantiated. This patch adds the deprecation warning when a new BufferedLogger is instantiated.

I think this should be enough to show the user every use of the BufferedLogger. At some point there must be an instantiation or a subclass definition. This is when a deprecation warning will be shown and these are the places that need modification.

I did not add deprecation warnings to every instance method because I think this would pollute the log and would not help to track down the problematic areas.

Member

senny commented Dec 25, 2012

@rafaelfranca what do you think?

@rafaelfranca rafaelfranca added a commit that referenced this pull request Dec 25, 2012

@rafaelfranca rafaelfranca Merge pull request #8608 from senny/8576_cant_inherit_from_deprecated…
…_buffered_logger

deprecation warning when BufferedLogger is instantiated
227d4e9

@rafaelfranca rafaelfranca merged commit 227d4e9 into rails:master Dec 25, 2012

@senny senny deleted the senny:8576_cant_inherit_from_deprecated_buffered_logger branch Dec 25, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment