Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Fix missing ending newline in db structure dump: #8651
It would also help if future changes need to append more data in this
What do you think of it?
This comment has been minimized.
This comment has been minimized.Show comment Hide comment
the Pull Requests on github are reflect the contents of your branch. This means, you can put whatever you want on the branch you created the PR from and it will be updated to reflect that content. For your situation you should be able to push the squashed commit to the branch like so (involves a force push):
Amazing, it worked!
@senny thank you for the detailed clarification. To be honest I must
However I now kind of understand it plays better with how GitHub
As a side note, the hash of the commit changed because I fixed a typo
This is a good principle to follow. I think it's important though to think about what you consider a public branch. The problems start when other people depend on your work. I would consider a branch in your own fork, which is open for discussion to still be a private branch. If someone depends on it, they need a good reason and should be able to fix the situation when your branch changes. I consider PR-Branches to be exposed local branches that you can reason about and you should be able to change them upside down.