Ensure assets aren't duplicated when using sprockets require. #8735

Merged
merged 1 commit into from Jan 10, 2013

Conversation

Projects
None yet
3 participants
Contributor

jejacks0n commented Jan 4, 2013

Addresses the problem by calling flatten on asset array before calling uniq.

I've created a separate pull request on rails/sprockets-rails that addresses the issue for Rails 4.

rails/sprockets-rails#33

@jejacks0n jejacks0n referenced this pull request in rails/sprockets-rails Jan 4, 2013

Merged

Ensure assets aren't duplicated for debug. #31 #33

Contributor

pboling commented Jan 4, 2013

👍

Owner

guilleiguaran commented Jan 6, 2013

Can you add an CHANGELOG entry, please? 😄

@ghost ghost assigned guilleiguaran Jan 6, 2013

Contributor

jejacks0n commented Jan 7, 2013

added CHANGELOG entry.

Owner

guilleiguaran commented Jan 10, 2013

@jejacks0n can you rebase this, GH reports "This pull request cannot be automatically merged."

Fixes issue where duplicate assets can be required with sprockets.
- addresses the problem by calling flatten on asset array before calling uniq.
- adds note to CHANGELOG.
Contributor

jejacks0n commented Jan 10, 2013

Should be good to go! Thanks. =)

guilleiguaran added a commit that referenced this pull request Jan 10, 2013

Merge pull request #8735 from jejacks0n/duplicate_asset_fix
Ensure assets aren't duplicated when using sprockets require.

@guilleiguaran guilleiguaran merged commit 002dfba into rails:3-2-stable Jan 10, 2013

Owner

guilleiguaran commented Jan 10, 2013

Thanks!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment