added marshal_load and marshal_dump for ProxyTestResult. Behavior of met... #8762

Merged
merged 1 commit into from Jan 5, 2013

Conversation

Projects
None yet
2 participants
@hsbt
Contributor

hsbt commented Jan 5, 2013

Ruby-2.0.0 later changed behaivior of method_missing. method_missing of any Object repond to marshal_dump and marshal_load when call with Marshal.dump and Marshal.load.

details of this behaivior discussion:

I think this problem is that ProxyTestResult calling marshal_load and marshal_dump but don't have these methods. I added it.

@tenderlove How do you think about this problem?

added marshal_load and marshal_dump for ProxyTestResult. Behavior of …
…method_missing with Marshal.dump and Marshal.load is changing in ruby 2.0.0 later.
@tenderlove

This comment has been minimized.

Show comment Hide comment
@tenderlove

tenderlove Jan 5, 2013

Member

I was hoping @nobu would change it back, but we should fix in Rails for now. Thanks!

Member

tenderlove commented Jan 5, 2013

I was hoping @nobu would change it back, but we should fix in Rails for now. Thanks!

tenderlove added a commit that referenced this pull request Jan 5, 2013

Merge pull request #8762 from hsbt/fix-marshal_load
added marshal_load and marshal_dump for ProxyTestResult. Behavior of met...

@tenderlove tenderlove merged commit ee1a03c into rails:master Jan 5, 2013

@hsbt hsbt deleted the hsbt:fix-marshal_load branch Jan 5, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment