Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Don't require 'turn' from rails/test_help #8801

Merged
merged 1 commit into from Jan 8, 2013

Conversation

Projects
None yet
3 participants
Contributor

ktheory commented Jan 7, 2013

If 'turn' is in the Gemfile with :require => nil, Rails should
respect that.

This supports the case where 'turn' may or may not be required
depending on different developers' preference or environment. E.g., you
require turn for local testing, but not on your CI server by putting
this in test/test_helper.rb:

require 'turn' if ENV['TURN']
@ktheory ktheory Don't require 'turn' from rails/test_help
If 'turn' is in the Gemfile with `:require => nil`, Rails should
respect that.

This supports the case where 'turn' may or may not be required
depending on different developers' preference or environment. E.g., you
require turn for local testing, but not on your CI server by putting
this in `test/test_helper.rb`:

    require 'turn' if ENV['TURN']
bc95767

@guilleiguaran guilleiguaran added a commit that referenced this pull request Jan 8, 2013

@guilleiguaran guilleiguaran Merge pull request #8801 from ktheory/dont_require_turn
Don't require 'turn' from rails/test_help
4200614

@guilleiguaran guilleiguaran merged commit 4200614 into rails:master Jan 8, 2013

Contributor

frodsan commented Jan 8, 2013

I wonder if this needed a CHANGELOG entry?

Owner

guilleiguaran commented Jan 8, 2013

I don't think so, actually I think this code was left just by accident, afaik I removed all the code related to Turn before rails 3.2.0

@ktheory ktheory deleted the ktheory:dont_require_turn branch Aug 20, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment