Extract ActionDispatch::PerformanceTest#8876
Merged
Merged
Conversation
guilleiguaran
added a commit
that referenced
this pull request
Jan 10, 2013
Extract ActionDispatch::PerformanceTest
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I extracted the performance tests and put them into a gem called "rails-perftest" https://github.com/rails/rails-perftest
Work:
rails benchmarkerandrails profilerThe extracted gem is a drop-in solution. Currently the
perftestgem's executable makes use of the pwd to determine theRails.root. We can replace this with the new binstubs but I'm not completely sure how to do it 😓