New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract ActionDispatch::PerformanceTest #8876

Merged
merged 3 commits into from Jan 10, 2013

Conversation

Projects
None yet
3 participants
@senny
Member

senny commented Jan 10, 2013

I extracted the performance tests and put them into a gem called "rails-perftest" https://github.com/rails/rails-perftest

Work:

  • The performance_testing Guide is the README of the new gem
  • Extracted performance test code
  • Modified the generators
  • Extracted rails benchmarker and rails profiler
  • Removed all references to the performance tests

The extracted gem is a drop-in solution. Currently the perftest gem's executable makes use of the pwd to determine the Rails.root. We can replace this with the new binstubs but I'm not completely sure how to do it 馃槗

guilleiguaran added a commit that referenced this pull request Jan 10, 2013

Merge pull request #8876 from senny/extract_performance_tests
Extract ActionDispatch::PerformanceTest

@guilleiguaran guilleiguaran merged commit 416a179 into rails:master Jan 10, 2013

@senny senny deleted the senny:extract_performance_tests branch Jan 10, 2013

@georgemillo

This comment has been minimized.

Show comment
Hide comment
@georgemillo

georgemillo Oct 27, 2016

Contributor

Just wondering why this was removed?

Contributor

georgemillo commented on 5ca7ddc Oct 27, 2016

Just wondering why this was removed?

This comment has been minimized.

Show comment
Hide comment
@senny

senny Oct 27, 2016

Member

@georgemillo this was extracted into a gem: https://github.com/rails/rails-perftest the guide was turned into the gems README.

Member

senny replied Oct 27, 2016

@georgemillo this was extracted into a gem: https://github.com/rails/rails-perftest the guide was turned into the gems README.

This comment has been minimized.

Show comment
Hide comment
@georgemillo

georgemillo Oct 27, 2016

Contributor

I see. Thanks!

Contributor

georgemillo replied Oct 27, 2016

I see. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment