Unprepared Visitor + unprepared_statement #8966

Merged
merged 1 commit into from Mar 8, 2013

Conversation

Projects
None yet
4 participants
Contributor

cfabianski commented Jan 16, 2013

Relates this issue #8743

Contributor

robworley commented Jan 17, 2013

Good for safely composing fragments of large SQL statements to avoid multiple round-trips between ruby and the db e.g. anonymous code blocks in PostgreSQL. 👍

Contributor

khustochka commented Feb 27, 2013

👍 Strongly support

@rafaelfranca rafaelfranca commented on an outdated diff Feb 27, 2013

..._record/connection_adapters/abstract_mysql_adapter.rb
end
end
+ def unprepared_visitor
@rafaelfranca

rafaelfranca Feb 27, 2013

Owner

This method should be in the abstract adapter.

Owner

rafaelfranca commented Feb 27, 2013

hmmm, seems a good idea. @tenderlove WDYT?

Contributor

cfabianski commented Feb 27, 2013

@rafaelfranca updated following your comment. Was tired when I did this :-)

Contributor

khustochka commented Mar 1, 2013

I'd suspect the Rails guys would like the commits squashed :)

Contributor

cfabianski commented Mar 1, 2013

I'll rebase them as soon as they will at least give me a sign of agreement ^_^

Contributor

cfabianski commented Mar 1, 2013

Done just in case ;-)

Owner

rafaelfranca commented Mar 7, 2013

Could you add a CHANGELOG entry?

Contributor

cfabianski commented Mar 8, 2013

rafaelfranca merged commit 9f54921 into rails:master Mar 8, 2013

@Fortisque Fortisque added a commit to Fortisque/rails that referenced this pull request Mar 25, 2014

@Fortisque Fortisque Continue to use the bind parameter syntax even on non prepared statem…
…ents

Appears to effectively revert rails#8966
He was using the non prepared statement so that .to_sql would return
sql with parameters already bound, although this doesn't relate
to whether we are using prepared statements or not.
Also related rails#8966
8db2ed3

@Fortisque Fortisque added a commit to Fortisque/rails that referenced this pull request Mar 25, 2014

@Fortisque Fortisque Continue to use the bind parameter syntax even on non prepared statem…
…ents

Appears to effectively revert #8966
He was using the non prepared statement so that .to_sql would return
sql with parameters already bound, although this doesn't relate
to whether we are using prepared statements or not.
Also related rails@fd39847
1722559

cfabianski deleted the cfabianski:disable_prepared_statement_when_preparing_a_query branch Feb 12, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment